Sign upLogin

CiscoUcs/imcsdk

View on GitHub
Star
imcsdk/apis/server/adaptor.py

Summary

Maintainability
F
5 days
Test Coverage

File adaptor.py has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2016 Cisco Systems, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in imcsdk/apis/server/adaptor.py - About 2 hrs to fix

    Function vnic_create has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def vnic_create(handle,
    Severity: Major
    Found in imcsdk/apis/server/adaptor.py - About 1 hr to fix

      Function vhba_create has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def vhba_create(handle, adaptor_slot, name, channel_number, wwnn, wwpn,
      Severity: Major
      Found in imcsdk/apis/server/adaptor.py - About 1 hr to fix

        Function adaptor_properties_set has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def adaptor_properties_set(handle, adaptor_slot, lldp=None, fip_mode=None,
        Severity: Major
        Found in imcsdk/apis/server/adaptor.py - About 1 hr to fix

          Function vnic_get has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def vnic_get(handle, adaptor_slot, name, server_id=1, **kwargs):
          Severity: Minor
          Found in imcsdk/apis/server/adaptor.py - About 35 mins to fix

            Function vnic_delete has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def vnic_delete(handle, name, adaptor_slot=1, server_id=1, **kwargs):
            Severity: Minor
            Found in imcsdk/apis/server/adaptor.py - About 35 mins to fix

              Function vhba_get has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def vhba_get(handle, adaptor_slot, name, server_id=1, **kwargs):
              Severity: Minor
              Found in imcsdk/apis/server/adaptor.py - About 35 mins to fix

                Function vhba_delete has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def vhba_delete(handle, adaptor_slot, name, server_id=1, **kwargs):
                Severity: Minor
                Found in imcsdk/apis/server/adaptor.py - About 35 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def vnic_create(handle,
                name,
                adaptor_slot=1,
                channel_number=None,
                mac="AUTO",
                  Severity: Major
                  Found in imcsdk/apis/server/adaptor.py and 1 other location - About 1 day to fix
                  imcsdk/apis/v2/server/adaptor.py on lines 167..228

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 179.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def vhba_create(handle, adaptor_slot, name, channel_number, wwnn, wwpn,
                port_profile=None, san_boot=False, uplink_port=0,
                server_id=1, **kwargs):
    """
    This method is used to create a new vhba
                  Severity: Major
                  Found in imcsdk/apis/server/adaptor.py and 1 other location - About 1 day to fix
                  imcsdk/apis/v2/server/adaptor.py on lines 271..320

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 148.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                  def vhba_get(handle, adaptor_slot, name, server_id=1, **kwargs):
    """
    This method is used to get a vhba
    Args:
        handle (ImcHandle)
                  Severity: Major
                  Found in imcsdk/apis/server/adaptor.py and 3 other locations - About 2 hrs to fix
                  imcsdk/apis/server/adaptor.py on lines 145..163
                  imcsdk/apis/v2/server/adaptor.py on lines 146..164
                  imcsdk/apis/v2/server/adaptor.py on lines 250..268

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 57.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                  def vnic_get(handle, adaptor_slot, name, server_id=1, **kwargs):
    """
    This method is used to get a vnic
    Args:
        handle (ImcHandle)
                  Severity: Major
                  Found in imcsdk/apis/server/adaptor.py and 3 other locations - About 2 hrs to fix
                  imcsdk/apis/server/adaptor.py on lines 249..267
                  imcsdk/apis/v2/server/adaptor.py on lines 146..164
                  imcsdk/apis/v2/server/adaptor.py on lines 250..268

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 57.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def adaptor_reset(handle, adaptor_slot, server_id=1, **kwargs):
    """

    Args:
        handle (ImcHandle)
                  Severity: Major
                  Found in imcsdk/apis/server/adaptor.py and 1 other location - About 2 hrs to fix
                  imcsdk/apis/v2/server/adaptor.py on lines 126..143

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def vnic_delete(handle, name, adaptor_slot=1, server_id=1, **kwargs):
    """
    This method is used to delete a vnic
    Args:
        handle (ImcHandle)
                  Severity: Major
                  Found in imcsdk/apis/server/adaptor.py and 1 other location - About 1 hr to fix
                  imcsdk/apis/v2/server/adaptor.py on lines 231..247

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 42.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def vhba_delete(handle, adaptor_slot, name, server_id=1, **kwargs):
    """
    This method is used to delete a vnic
    Args:
        handle (ImcHandle)
                  Severity: Major
                  Found in imcsdk/apis/server/adaptor.py and 1 other location - About 1 hr to fix
                  imcsdk/apis/v2/server/adaptor.py on lines 323..339

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 41.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def adaptor_properties_get(handle, adaptor_slot, server_id=1, **kwargs):
    """
    This method is used to get the vic adaptor properties
    Args:
        handle (ImcHandle)
                  Severity: Major
                  Found in imcsdk/apis/server/adaptor.py and 1 other location - About 1 hr to fix
                  imcsdk/apis/v2/server/adaptor.py on lines 49..70

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 41.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 3 locations. Consider refactoring.
                  Open

                  def _get_adaptor_dn(handle, adaptor_slot, server_id=1):
    server_dn = get_server_dn(handle, server_id)
    return(server_dn + "/adaptor-" + str(adaptor_slot))
                  Severity: Major
                  Found in imcsdk/apis/server/adaptor.py and 2 other locations - About 1 hr to fix
                  imcsdk/apis/v2/server/adaptor.py on lines 24..26
                  imcsdk/apis/v2/server/vic.py on lines 50..52

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 39.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status