Sign upLogin

CiscoUcs/imcsdk

View on GitHub
Star
imcsdk/apis/server/inventory.py

Summary

Maintainability
F
3 wks
Test Coverage

Function _get_inventory_html has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

def _get_inventory_html(inventory, file_name, spec=inventory_spec):
    if file_name is None:
        raise ImcOperationError("Inventory collection",
                                "file_name is a required parameter")
    f = open(file_name, "w")
Severity: Minor
Found in imcsdk/apis/server/inventory.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _get_inventory has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

def _get_inventory(handle, comp, spec, inventory):
    component = spec[comp]
    class_id = component["class_id"]
    mos = handle.query_classid(class_id)
Severity: Minor
Found in imcsdk/apis/server/inventory.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File inventory.py has 352 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2016 Cisco Systems, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in imcsdk/apis/server/inventory.py - About 4 hrs to fix

    Function _get_inventory_csv has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    def _get_inventory_csv(inventory, file_name, spec=inventory_spec):
    import csv
    if file_name is None:
        raise ImcOperationError("Inventory collection",
                                "file_name is a required parameter")
    Severity: Minor
    Found in imcsdk/apis/server/inventory.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function inventory_get has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    def inventory_get(handle,
                  component="all",
                  file_format="json",
                  file_name=None,
                  spec=inventory_spec):
    Severity: Minor
    Found in imcsdk/apis/server/inventory.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if key not in entry:
                        continue
                    row_val.append(entry[key])
    Severity: Major
    Found in imcsdk/apis/server/inventory.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if _should_ignore(component, sub_mo):
                        continue
                    _sanitize_and_store(mo_dict, prop, sub_mo)
      Severity: Major
      Found in imcsdk/apis/server/inventory.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if key not in entry:
                        continue
                    row_val.append(entry[key])
        Severity: Major
        Found in imcsdk/apis/server/inventory.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if each is None:
                        each = ""
                    html += "<td>" + each + "</td>"
          Severity: Major
          Found in imcsdk/apis/server/inventory.py - About 45 mins to fix

            Function inventory_get has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def inventory_get(handle,
            Severity: Minor
            Found in imcsdk/apis/server/inventory.py - About 35 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              Severity: Major
              Found in imcsdk/apis/server/inventory.py and 1 other location - About 2 wks to fix
              imcsdk/apis/v2/server/inventory.py on lines 0..406

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 1943.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status