Sign upLogin

CiscoUcs/imcsdk

View on GitHub
Star
imcsdk/apis/server/serveractions.py

Summary

Maintainability
F
1 wk
Test Coverage

File serveractions.py has 261 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2016 Cisco Systems, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in imcsdk/apis/server/serveractions.py - About 2 hrs to fix

    Function server_power_down has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def server_power_down(handle, timeout=60, interval=5, server_id=1, **kwargs):
    Severity: Minor
    Found in imcsdk/apis/server/serveractions.py - About 35 mins to fix

      Function server_power_cycle has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def server_power_cycle(handle, timeout=120, interval=5, server_id=1, **kwargs):
      Severity: Minor
      Found in imcsdk/apis/server/serveractions.py - About 35 mins to fix

        Function server_power_down_gracefully has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def server_power_down_gracefully(handle, timeout=120, interval=5,
        Severity: Minor
        Found in imcsdk/apis/server/serveractions.py - About 35 mins to fix

          Function _wait_for_power_state has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _wait_for_power_state(handle, state, timeout=60, interval=5, server_id=1):
          Severity: Minor
          Found in imcsdk/apis/server/serveractions.py - About 35 mins to fix

            Function server_power_up has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def server_power_up(handle, timeout=60, interval=5, server_id=1, **kwargs):
            Severity: Minor
            Found in imcsdk/apis/server/serveractions.py - About 35 mins to fix

              Function _wait_for_power_state has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def _wait_for_power_state(handle, state, timeout=60, interval=5, server_id=1):
    """
    This method should be called after a power state change has been triggered.
    It will poll the server and return when the desired state is achieved.
              Severity: Minor
              Found in imcsdk/apis/server/serveractions.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              Severity: Major
              Found in imcsdk/apis/server/serveractions.py and 1 other location - About 1 wk to fix
              imcsdk/apis/v2/server/serveractions.py on lines 0..367

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 1005.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status