Sign upLogin

CiscoUcs/imcsdk

View on GitHub
Star
imcsdk/apis/v2/server/pxe.py

Summary

Maintainability
D
2 days
Test Coverage

Function _parse_pxe_devices has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

def _parse_pxe_devices(devices):
    #  segregate devices on the basis of interface source
    #  slot_interface_map (dict)
    #  key: slot + "~~~" + interface_name
    #  value: boot device
Severity: Minor
Found in imcsdk/apis/v2/server/pxe.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _enable_pxe_boot_mac has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

def _enable_pxe_boot_mac(handle, mac_address_map, ep_mac_map):
    # if pxe device mac address matches endpoint vnic
    # then enable pxe boot for resp vnic

    log.debug("enabling pxe boot on vnics using mac address")
Severity: Minor
Found in imcsdk/apis/v2/server/pxe.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File pxe.py has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2019 Cisco Systems, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in imcsdk/apis/v2/server/pxe.py - About 2 hrs to fix

    Function _derive_logical_port has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def _derive_logical_port(handle, affected_slots):
    # fetch the pcilink and order of all vnics at end point
    # slot_vnicname_map (dict)
    # key: slot~~~vnicname
    # value: PxeBootDevice Instance
    Severity: Minor
    Found in imcsdk/apis/v2/server/pxe.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _enable_pxe_boot_vnic has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def _enable_pxe_boot_vnic(handle, slot_vnicname_map, ep_slot_vnicname_map):
    # if pxe device with slot and vnicname matches endpoint vnic
    # then enable pxe boot for resp vnic

    log.debug("enabling pxe boot on vnics using slot and vnicname")
    Severity: Minor
    Found in imcsdk/apis/v2/server/pxe.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if missing_mac_str:
                        missing_mac_str += "\n"
                    missing_mac_str += err_str
    Severity: Major
    Found in imcsdk/apis/v2/server/pxe.py - About 45 mins to fix

      Function _parse_vnic_gen_profiles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def _parse_vnic_gen_profiles(handle):
    # slot_vnicname_map (dict)
    # key: slot~~~vnicname
    # value: PxeBootDevice Instance
    slot_vnicname_map = {}
      Severity: Minor
      Found in imcsdk/apis/v2/server/pxe.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _get_bootable_slot_vnicname has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def _get_bootable_slot_vnicname(handle):
    # get all the end point vnics
    vnics = handle.query_classid(class_id="AdaptorHostEthIf")
    if vnics is None:
        vnics = []
      Severity: Minor
      Found in imcsdk/apis/v2/server/pxe.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def __init__(self):
        self.boot_device = None
        self.slot = None
        self.vnic_name = None
        self.order = None
      Severity: Major
      Found in imcsdk/apis/v2/server/pxe.py and 1 other location - About 1 hr to fix
      imcsdk/imccoremeta.py on lines 525..532

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if len(mac_address_map) > 0:
        log.debug("PXE Devices with source MAC address:\n%s" % mac_address_map)
        _enable_pxe_boot_mac(handle, mac_address_map, ep_mac_map)
      Severity: Major
      Found in imcsdk/apis/v2/server/pxe.py and 1 other location - About 1 hr to fix
      imcsdk/apis/v2/server/pxe.py on lines 304..306

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if len(slot_vnicname_map) > 0:
        log.debug("PXE Devices with source name:\n%s" % slot_vnicname_map)
        _enable_pxe_boot_vnic(handle, slot_vnicname_map, ep_slot_vnicname_map)
      Severity: Major
      Found in imcsdk/apis/v2/server/pxe.py and 1 other location - About 1 hr to fix
      imcsdk/apis/v2/server/pxe.py on lines 308..310

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status