Sign upLogin

CiscoUcs/imcsdk

View on GitHub
Star
imcsdk/apis/v2/server/vic.py

Summary

Maintainability
F
5 days
Test Coverage

File vic.py has 701 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2016 Cisco Systems, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in imcsdk/apis/v2/server/vic.py - About 1 day to fix

    Function adaptor_set_all has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

    def adaptor_set_all(handle, adaptors=None, server_id=1, **kwargs):
    """
    Example:
        adaptor_set_all(handle,
                        adaptors=[
    Severity: Minor
    Found in imcsdk/apis/v2/server/vic.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _create_vic_object has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    def _create_vic_object(adaptor_mo, vic_name, vic_type, api_error_msg,
                       **kwargs):
    from imcsdk.imccoreutils import load_class
    from imcsdk.imccoreutils import find_class_id_in_mo_meta_ignore_case
    Severity: Minor
    Found in imcsdk/apis/v2/server/vic.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _ext_ethif_set_all has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def _ext_ethif_set_all(handle, ext_ethifs, adaptor_mo):
    """
    Example:
        _ext_ethif_set_all(handle,
                           ext_ethifs=[
    Severity: Minor
    Found in imcsdk/apis/v2/server/vic.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function vnic_create_all has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def vnic_create_all(handle, vnics=None, adaptors_to_reset=None,
                    server_id=1):
    """
    This method is used to create a new vnic
    Args:
    Severity: Minor
    Found in imcsdk/apis/v2/server/vic.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _create_vics_with_children has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def _create_vics_with_children(handle, vic_type, api_error_msg, vics,
                               adaptors_to_reset=None):
    """
    Internal method to create all vnics or vhbas objects which can be sent to
    end point for configuration
    Severity: Minor
    Found in imcsdk/apis/v2/server/vic.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _vic_delete_all_under_adaptors has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def _vic_delete_all_under_adaptors(handle, vic_type, adaptor_slots):
    import re

    if vic_type == "vnic":
        api_error_msg = VicConst.VNIC_ERROR_MSG
    Severity: Minor
    Found in imcsdk/apis/v2/server/vic.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _vic_get has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _vic_get(handle, adaptor_slot, name, vic_type, server_id=1):
    Severity: Minor
    Found in imcsdk/apis/v2/server/vic.py - About 35 mins to fix

      Function _create_vics_with_children has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _create_vics_with_children(handle, vic_type, api_error_msg, vics,
      Severity: Minor
      Found in imcsdk/apis/v2/server/vic.py - About 35 mins to fix

        Function _process_response has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _process_response(response, api, error_msg, callback=None, *cbargs):
        Severity: Minor
        Found in imcsdk/apis/v2/server/vic.py - About 35 mins to fix

          Function _create_vic_object has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _create_vic_object(adaptor_mo, vic_name, vic_type, api_error_msg,
          Severity: Minor
          Found in imcsdk/apis/v2/server/vic.py - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            def vhba_create(handle, server_id=1, send_request=True, **kwargs):
    """
    This method is used to create a new vhba
    Args:
        handle (ImcHandle)
            Severity: Major
            Found in imcsdk/apis/v2/server/vic.py and 1 other location - About 6 hrs to fix
            imcsdk/apis/v2/server/vic.py on lines 636..664

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 98.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            def vnic_create(handle, server_id=1, **kwargs):
    """
    This method is used to create a new vnic
    Args:
        handle (ImcHandle)
            Severity: Major
            Found in imcsdk/apis/v2/server/vic.py and 1 other location - About 6 hrs to fix
            imcsdk/apis/v2/server/vic.py on lines 818..857

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 98.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                if vic_type == "vnic":
        api_error_msg = VicConst.VNIC_ERROR_MSG
        ignore_vics = ['eth0', 'eth1']
    elif vic_type == "vhba":
        api_error_msg = VicConst.VHBA_ERROR_MSG
            Severity: Major
            Found in imcsdk/apis/v2/server/vic.py and 1 other location - About 2 hrs to fix
            imcsdk/apis/v2/server/vic.py on lines 592..597

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                if vic_type == "vnic":
        api_error_msg = VicConst.VNIC_ERROR_MSG
        ignore_vics = ['eth0', 'eth1']
    elif vic_type == "vhba":
        api_error_msg = VicConst.VHBA_ERROR_MSG
            Severity: Major
            Found in imcsdk/apis/v2/server/vic.py and 1 other location - About 2 hrs to fix
            imcsdk/apis/v2/server/vic.py on lines 484..489

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

            def _get_adaptor_dn(handle, adaptor_slot, server_id=1):
    server_dn = get_server_dn(handle, server_id)
    return(server_dn + "/adaptor-" + str(adaptor_slot))
            Severity: Major
            Found in imcsdk/apis/v2/server/vic.py and 2 other locations - About 1 hr to fix
            imcsdk/apis/server/adaptor.py on lines 24..26
            imcsdk/apis/v2/server/adaptor.py on lines 24..26

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 39.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status