Sign upLogin

CiscoUcs/imcsdk

View on GitHub
Star
imcsdk/mometa/adaptor/AdaptorEthISCSIProfile.py

Summary

Maintainability
F
2 wks
Test Coverage

Function __init__ has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def __init__(self, parent_mo_or_dn, **kwargs):
        self._dirty_mask = 0
        self.dhcp_iscsi = None
        self.dhcp_id = None
        self.dhcp_network_settings = None
Severity: Minor
Found in imcsdk/mometa/adaptor/AdaptorEthISCSIProfile.py - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            "classic": {
            "dhcp_iscsi": MoPropertyMeta("dhcp_iscsi", "dhcpISCSI", "string", VersionMeta.Version151f, MoPropertyMeta.READ_WRITE, 0x2, None, None, None, ["Disabled", "Enabled", "disabled", "enabled"], []),
            "dhcp_id": MoPropertyMeta("dhcp_id", "dhcpId", "string", VersionMeta.Version151f, MoPropertyMeta.READ_WRITE, 0x4, 0, 63, None, [], []),
            "dhcp_network_settings": MoPropertyMeta("dhcp_network_settings", "dhcpNetworkSettings", "string", VersionMeta.Version151f, MoPropertyMeta.READ_WRITE, 0x8, None, None, None, ["Disabled", "Enabled", "disabled", "enabled"], []),
            "dhcp_timeout": MoPropertyMeta("dhcp_timeout", "dhcpTimeout", "uint", VersionMeta.Version151f, MoPropertyMeta.READ_WRITE, 0x10, None, None, None, [], ["60-300"]),
    Severity: Major
    Found in imcsdk/mometa/adaptor/AdaptorEthISCSIProfile.py and 1 other location - About 6 days to fix
    imcsdk/mometa/adaptor/AdaptorEthISCSIProfile.py on lines 63..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 694.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            "modular": {
            "dhcp_iscsi": MoPropertyMeta("dhcp_iscsi", "dhcpISCSI", "string", VersionMeta.Version2013e, MoPropertyMeta.READ_WRITE, 0x2, None, None, None, ["Disabled", "Enabled", "disabled", "enabled"], []),
            "dhcp_id": MoPropertyMeta("dhcp_id", "dhcpId", "string", VersionMeta.Version2013e, MoPropertyMeta.READ_WRITE, 0x4, 0, 63, None, [], []),
            "dhcp_network_settings": MoPropertyMeta("dhcp_network_settings", "dhcpNetworkSettings", "string", VersionMeta.Version2013e, MoPropertyMeta.READ_WRITE, 0x8, None, None, None, ["Disabled", "Enabled", "disabled", "enabled"], []),
            "dhcp_timeout": MoPropertyMeta("dhcp_timeout", "dhcpTimeout", "uint", VersionMeta.Version2013e, MoPropertyMeta.READ_WRITE, 0x10, None, None, None, [], ["60-300"]),
    Severity: Major
    Found in imcsdk/mometa/adaptor/AdaptorEthISCSIProfile.py and 1 other location - About 6 days to fix
    imcsdk/mometa/adaptor/AdaptorEthISCSIProfile.py on lines 27..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 694.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def __init__(self, parent_mo_or_dn, **kwargs):
        self._dirty_mask = 0
        self.dhcp_iscsi = None
        self.dhcp_id = None
        self.dhcp_network_settings = None
    Severity: Major
    Found in imcsdk/mometa/adaptor/AdaptorEthISCSIProfile.py and 2 other locations - About 2 days to fix
    imcsdk/mometa/aaa/AaaLdap.py on lines 185..219
    imcsdk/mometa/osi/OsiStart.py on lines 196..230

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 244.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        prop_map = {

        "classic": {
            "dhcpISCSI": "dhcp_iscsi", 
            "dhcpId": "dhcp_id",
    Severity: Major
    Found in imcsdk/mometa/adaptor/AdaptorEthISCSIProfile.py and 3 other locations - About 1 day to fix
    imcsdk/mometa/aaa/AaaLdap.py on lines 109..180
    imcsdk/mometa/memory/MemoryPersistentMemoryUnit.py on lines 234..305
    imcsdk/mometa/osi/OsiStart.py on lines 120..191

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 147.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status