Sign upLogin

CleverStack/clever-accounts

View on GitHub
Star

Showing 14 of 14 total issues

Function exports has 171 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(Controller, AccountService, config, async, $PermissionController) {
  var autoRouting = [];

  if ($PermissionController !== null) {
    autoRouting.push(
Severity: Major
Found in controllers/AccountController.js - About 6 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        getAction: function() {
      if (this.req.query.AccountId !== undefined && this.req.query.AccountId !== this.req.user.Account.id) {
        return this.handleServiceMessage({ statuscode: 400, message: this.Class.service.model.modelName + ' doesn\'t exist.' });
      }
      this.req.query.id = this.req.user.Account.id;
    Severity: Major
    Found in controllers/AccountController.js and 2 other locations - About 6 hrs to fix
    controllers/AccountController.js on lines 207..213
    controllers/AccountController.js on lines 215..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        putAction: function() {
      if (this.req.query.AccountId !== undefined && this.req.query.AccountId !== this.req.user.Account.id) {
        return this.handleServiceMessage({ statuscode: 400, message: this.Class.service.model.modelName + ' doesn\'t exist.' });
      }
      this.req.query.id = this.req.user.Account.id;
    Severity: Major
    Found in controllers/AccountController.js and 2 other locations - About 6 hrs to fix
    controllers/AccountController.js on lines 199..205
    controllers/AccountController.js on lines 215..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        deleteAction: function() {
      if (this.req.query.AccountId !== undefined && this.req.query.AccountId !== this.req.user.Account.id) {
        return this.handleServiceMessage({ statuscode: 400, message: this.Class.service.model.modelName + ' doesn\'t exist.' });
      }
      this.req.query.id = this.req.user.Account.id;
    Severity: Major
    Found in controllers/AccountController.js and 2 other locations - About 6 hrs to fix
    controllers/AccountController.js on lines 199..205
    controllers/AccountController.js on lines 207..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function exports has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function(Controller, AccountService, config, async, $PermissionController) {
  var autoRouting = [];

  if ($PermissionController !== null) {
    autoRouting.push(
    Severity: Minor
    Found in controllers/AccountController.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addAccountIdToRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        addAccountIdToRequest: function(requiredRoutes) {
      if (typeof requiredRoutes !== 'object') {
        requiredRoutes = {
          all: [ requiredRoutes !== undefined ? requiredRoutes : true ]
        };
    Severity: Major
    Found in controllers/AccountController.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                        } else {
                    if (!isAdmin || (!!isAdmin && !accountId)) {
                      req.query.AccountId = parseInt(!/^[0-9a-fA-F]{24}$/.test(user.Account.id) ? user.Account.id : user.Account._id, 10);
                    }
                  }
      Severity: Major
      Found in controllers/AccountController.js and 1 other location - About 2 hrs to fix
      controllers/AccountController.js on lines 157..161

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                        if (method === 'post' || method === 'put') {
                    if (!isAdmin || (!!isAdmin && !accountId)) {
                      req.body.AccountId = parseInt(!/^[0-9a-fA-F]{24}$/.test(user.Account.id) ? user.Account.id : user.Account._id, 10);
                    }
                  } else {
      Severity: Major
      Found in controllers/AccountController.js and 1 other location - About 2 hrs to fix
      controllers/AccountController.js on lines 161..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function exports has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(Promise, Service, AccountModel, config, UserService, _) {
  return Service.extend({

    model: AccountModel,
      Severity: Major
      Found in services/AccountService.js - About 2 hrs to fix

        Function create has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            create: function(values, queryOptions) {
      var createAccount = this._super;

      queryOptions  = queryOptions || {};
        Severity: Major
        Found in services/AccountService.js - About 2 hrs to fix

          Function exports has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(Model, config, utils, UserModel) {
  return Model.extend('Account',
  {
    type              : config['clever-accounts'].driver || 'ORM',
    timeStampable     : true,
          Severity: Minor
          Found in models/AccountModel.js - About 1 hr to fix

            Function exports has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            module.exports = function(Promise, Service, AccountModel, config, UserService, _) {
            Severity: Minor
            Found in services/AccountService.js - About 45 mins to fix

              Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              module.exports = function(Controller, AccountService, config, async, $PermissionController) {
              Severity: Minor
              Found in controllers/AccountController.js - About 35 mins to fix

                Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                module.exports = function(Promise, Service, AccountModel, config, UserService, _) {
  return Service.extend({

    model: AccountModel,
                Severity: Minor
                Found in services/AccountService.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language