Sign upLogin

CleverStack/clever-users

View on GitHub
Star

Showing 23 of 23 total issues

Function exports has 296 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(config, Controller, Promise, UserService, AccountController, AuthController, Exceptions) {

  var UserController = Controller.extend({
    service: UserService,
    route: '/auth/user/:id/?|/auth/user/:id/:action/?|/auth/users/?|/auth/users/:action/?',
Severity: Major
Found in controllers/UserController.js - About 1 day to fix

    Function exports has 179 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(Service, Promise, Exceptions, config, utils, UserModel) {
  var crypto      = require('crypto')
    , moment      = require('moment')
    , ejsRenderer = utils.ejsRenderer
    , mailer      = utils.mailer
    Severity: Major
    Found in services/UserService.js - About 7 hrs to fix

      Function exports has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function(config, Controller, Promise, UserService, AccountController, AuthController, Exceptions) {

  var UserController = Controller.extend({
    service: UserService,
    route: '/auth/user/:id/?|/auth/user/:id/:action/?|/auth/users/?|/auth/users/:action/?',
      Severity: Minor
      Found in controllers/UserController.js - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 149 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {
  'use strict';

  var fs            = require('fs')
    , path          = require('path')
      Severity: Major
      Found in Gruntfile.js - About 5 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    function routeRequiresLogin(callback) {
              var actionName = (!!action ? action : method) + 'Action';

              if (typeof requiredRoutes[ actionName ] !== 'undefined') {
                if (requiredRoutes[ actionName ] !== null) {
        Severity: Major
        Found in controllers/UserController.js and 1 other location - About 4 hrs to fix
        controllers/UserController.js on lines 91..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    function routeRequiresLogin(callback) {
              var actionName = (!!action ? action : method) + 'Action';

              if (typeof requiredRoutes[ actionName ] !== 'undefined') {
                if (requiredRoutes[ actionName ] !== null) {
        Severity: Major
        Found in controllers/UserController.js and 1 other location - About 4 hrs to fix
        controllers/UserController.js on lines 167..183

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function(grunt) {
  'use strict';

  var fs            = require('fs')
    , path          = require('path')
        Severity: Minor
        Found in Gruntfile.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File UserController.js has 302 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        var async      = require('async')
  , underscore = require('underscore')
  , passport   = require('passport')
  , util       = require('util');
        Severity: Minor
        Found in controllers/UserController.js - About 3 hrs to fix

          Function exports has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function(Service, Promise, Exceptions, config, utils, UserModel) {
  var crypto      = require('crypto')
    , moment      = require('moment')
    , ejsRenderer = utils.ejsRenderer
    , mailer      = utils.mailer
          Severity: Minor
          Found in services/UserService.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(Model, config) {
  return Model.extend( 'User',
  {
    type            : config['clever-users'].driver || 'ORM',
    timeStampable   : true,
          Severity: Major
          Found in models/UserModel.js - About 2 hrs to fix

            Function requiresAdminRights has 52 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                requiresAdminRights: function(requiredRoutes) {
      if (typeof requiredRoutes !== 'object') {
        requiredRoutes = {
          all: [ requiredRoutes !== undefined ? requiredRoutes : true ]
        }
            Severity: Major
            Found in controllers/UserController.js - About 2 hrs to fix

              Function requiresLogin has 52 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  requiresLogin: function(requiredRoutes) {
      if (typeof requiredRoutes !== 'object') {
        requiredRoutes = {
          all: [ requiredRoutes !== undefined ? requiredRoutes : true ]
        }
              Severity: Major
              Found in controllers/UserController.js - About 2 hrs to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (!action && method === 'get' && /^\/[^\/]+\/?$/ig.test(req.url)) {
          action = 'list';
        } else if (/^[0-9a-fA-F]{24}$/.test(action) || !isNaN(action)) {
          action = 'get';
        }
                Severity: Major
                Found in controllers/UserController.js and 1 other location - About 1 hr to fix
                controllers/UserController.js on lines 159..163

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 73.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (!action && method === 'get' && /^\/[^\/]+\/?$/ig.test(req.url)) {
          action = 'list';
        } else if (/^[0-9a-fA-F]{24}$/.test(action) || !isNaN(action)) {
          action = 'get';
        }
                Severity: Major
                Found in controllers/UserController.js and 1 other location - About 1 hr to fix
                controllers/UserController.js on lines 83..87

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 73.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                              when: function(answers) {
                if (answers[ 'cleverusers.overwrite' ] === undefined || answers[ 'cleverusers.overwrite' ] === true) {
                  return true;
                } else {
                  grunt.fail.fatal('Username `' + answers[ 'cleverusers.username' ] + '` already exists in seed data and you chose not to overwrite it!');
                Severity: Major
                Found in Gruntfile.js and 1 other location - About 1 hr to fix
                Gruntfile.js on lines 97..103

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 72.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                              when: function(answers) {
                if (answers[ 'cleverusers.overwrite' ] === undefined || answers[ 'cleverusers.overwrite' ] === true) {
                  return true;
                } else {
                  grunt.fail.fatal('Email `' + answers[ 'cleverusers.email' ] + '` already exists in seed data and you chose not to overwrite it!');
                Severity: Major
                Found in Gruntfile.js and 1 other location - About 1 hr to fix
                Gruntfile.js on lines 60..66

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 72.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function create has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    create: function(data, options) {
      var create = this._super;

      options = options || {};
                Severity: Minor
                Found in services/UserService.js - About 1 hr to fix

                  Function resetPasswordAction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      resetPasswordAction: function(req) {
      var userId      = req.body.id || req.body.user ||req.query.user
        , password    = req.body.password || req.query.password
        , token       = req.body.token || req.body.t || req.query.token || req.query.t;
                  Severity: Minor
                  Found in controllers/UserController.js - About 1 hr to fix

                    Function mailPasswordRecoveryToken has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        mailPasswordRecoveryToken: function(recoveryData) {
      var payload = {
        to       : recoveryData.user.email,
        from     : emailConfig.fromEmail,
        fromname : emailConfig.fromName,
                    Severity: Minor
                    Found in services/UserService.js - About 1 hr to fix

                      Function exports has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      module.exports = function(config, Controller, Promise, UserService, AccountController, AuthController, Exceptions) {
                      Severity: Major
                      Found in controllers/UserController.js - About 50 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language