Cloud-CV/EvalAI

View on GitHub
apps/challenges/models.py

Summary

Maintainability
C
1 day
Test Coverage

File models.py has 608 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from __future__ import unicode_literals

from django.contrib.auth.models import User
from django.core import serializers
from django.db.models.signals import pre_save
Severity: Major
Found in apps/challenges/models.py - About 1 day to fix

    Function create_eks_cluster_or_ec2_for_challenge has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def create_eks_cluster_or_ec2_for_challenge(sender, instance, created, **kwargs):
        field_name = "approved_by_admin"
        import challenges.aws_utils as aws
    
        if not created and is_model_field_changed(instance, field_name):
    Severity: Minor
    Found in apps/challenges/models.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status