Sign upLogin

Cloud-CV/EvalAI

View on GitHub
Star
frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts

Summary

Maintainability
F
4 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should show modal and successfully edit the evaluation details', () => {
    const updatedEvaluationDetails = 'Updated challenge evaluation details';
    const expectedSuccessMsg = 'The evaluation details is successfully updated!';
    spyOn(apiService, 'patchUrl').and.returnValue(
      new Observable((observer) => {
Severity: Major
Found in frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts and 1 other location - About 1 day to fix
frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts on lines 87..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 238.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should show modal and successfully edit the terms and conditions', () => {
    const updatedTermsAndConditions = 'Updated terms and conditions of challenge';
    const expectedSuccessMsg = 'The terms and conditions are successfully updated!';
    spyOn(apiService, 'patchUrl').and.returnValue(
      new Observable((observer) => {
Severity: Major
Found in frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts and 1 other location - About 1 day to fix
frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts on lines 46..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 238.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('should handle the API error for `editTermsAndConditions` method', () => {
    const updatedTermsAndConditions = 'Updated terms and conditions of challenge';
    const expectedErrorMsg = {
      error: 'Api error',
    };
Severity: Major
Found in frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts and 2 other locations - About 7 hrs to fix
frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts on lines 67..85
frontend_v2/src/app/components/challenge/challengeoverview/challengeoverview.component.spec.ts on lines 63..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 183.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('should handle the API error for `editEvaluationCriteria` method', () => {
    const updatedEvaluationDetails = 'Updated challenge evaluation details';
    const expectedErrorMsg = {
      error: 'Api error',
    };
Severity: Major
Found in frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts and 2 other locations - About 7 hrs to fix
frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts on lines 108..126
frontend_v2/src/app/components/challenge/challengeoverview/challengeoverview.component.spec.ts on lines 63..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 183.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  beforeEach(async(() => {
    TestBed.configureTestingModule({
      declarations: [ChallengeevaluationComponent],
      providers: [ChallengeService, ApiService, GlobalService, AuthService, EndpointsService],
      imports: [RouterTestingModule, HttpClientModule],
Severity: Major
Found in frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.spec.ts and 2 other locations - About 1 hr to fix
frontend_v2/src/app/components/challenge/challengeoverview/challengeoverview.component.spec.ts on lines 18..24
frontend_v2/src/app/components/challenge/challengephases/phasecard/phasecard.component.spec.ts on lines 16..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status