Sign upLogin

Cloud-CV/EvalAI

View on GitHub
Star
frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts

Summary

Maintainability
D
2 days
Test Coverage

File challengeleaderboard.component.ts has 436 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Component, OnInit, QueryList, ViewChildren, AfterViewInit, OnDestroy } from '@angular/core';
import { MatDialog } from '@angular/material/dialog';
import { Router, ActivatedRoute } from '@angular/router';

// import component
Severity: Minor
Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts - About 6 hrs to fix

    ChallengeleaderboardComponent has 27 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
  selector: 'app-challengeleaderboard',
  templateUrl: './challengeleaderboard.component.html',
  styleUrls: ['./challengeleaderboard.component.scss'],
})
    Severity: Minor
    Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts - About 3 hrs to fix

      Function selectPhaseSplitId has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        selectPhaseSplitId(id, self) {
    let i = 0;
    for (i = 0; i < self.filteredPhaseSplits.length; i++) {
      if (parseInt(id, 10) === self.filteredPhaseSplits[i]['id']) {
        self.selectedPhaseSplit = self.filteredPhaseSplits[i];
      Severity: Minor
      Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function phaseSplitSelected has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        phaseSplitSelected(phaseSplit) {
    const SELF = this;
    SELF.selectedPhaseSplit = phaseSplit;
    SELF.highlightedEntry = null;
      Severity: Minor
      Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts - About 1 hr to fix

        Function selectPhaseSplitId has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          selectPhaseSplitId(id, self) {
    let i = 0;
    for (i = 0; i < self.filteredPhaseSplits.length; i++) {
      if (parseInt(id, 10) === self.filteredPhaseSplits[i]['id']) {
        self.selectedPhaseSplit = self.filteredPhaseSplits[i];
        Severity: Minor
        Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts - About 1 hr to fix

          Function filterPhases has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            filterPhases() {
    if (this.phases.length > 0 && this.phaseSplits.length > 0) {
      for (let i = 0; i < this.phaseSplits.length; i++) {
        if (this.phaseSplits[i].visibility !== this.challengePhaseVisibility.public) {
          this.phaseSplits[i].showPrivate = true;
          Severity: Minor
          Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function phaseSplitSelected has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            phaseSplitSelected(phaseSplit) {
    const SELF = this;
    SELF.selectedPhaseSplit = phaseSplit;
    SELF.highlightedEntry = null;
          Severity: Minor
          Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return 0;
          Severity: Major
          Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              constructor(
    private authService: AuthService,
    private router: Router,
    private route: ActivatedRoute,
    private challengeService: ChallengeService,
            Severity: Major
            Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts and 1 other location - About 2 hrs to fix
            frontend_v2/src/app/components/challenge/challengesubmit/challengesubmit.component.ts on lines 238..247

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else if (SELF.router.url.split('/').length === 5) {
      SELF.router.navigate(['../' + phaseSplit['id'] + '/' + SELF.encodeMetricURI(metricName)], { relativeTo: this.route });
    } else if (SELF.router.url.split('/').length === 6) {
      SELF.router.navigate(['../../' + phaseSplit['id'] + '/' + SELF.encodeMetricURI(metricName)], { relativeTo: this.route });
    }
            Severity: Major
            Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts and 1 other location - About 1 hr to fix
            frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts on lines 362..364

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else if (SELF.router.url.split('/').length === 6) {
      SELF.router.navigate(['../../' + phaseSplit['id'] + '/' + SELF.encodeMetricURI(metricName)], { relativeTo: this.route });
    }
            Severity: Major
            Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts and 1 other location - About 1 hr to fix
            frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts on lines 360..364

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                this.challengeService.currentPhaseSplit.subscribe((phaseSplits) => {
      this.phaseSplits = phaseSplits;
      this.filterPhases();
    });
            Severity: Minor
            Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts and 2 other locations - About 35 mins to fix
            frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.ts on lines 52..55
            frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts on lines 254..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                this.challengeService.currentPhases.subscribe((phases) => {
      this.phases = phases;
      this.filterPhases();
    });
            Severity: Minor
            Found in frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts and 2 other locations - About 35 mins to fix
            frontend_v2/src/app/components/challenge/challengeevaluation/challengeevaluation.component.ts on lines 52..55
            frontend_v2/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts on lines 258..261

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status