Sign upLogin

Cloud-CV/EvalAI

View on GitHub
Star
scripts/workers/code_upload_submission_worker.py

Summary

Maintainability
F
5 days
Test Coverage

File code_upload_submission_worker.py has 729 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import logging
import os
import signal
import sys
Severity: Major
Found in scripts/workers/code_upload_submission_worker.py - About 1 day to fix

    Function update_failed_jobs_and_send_logs has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
    Open

    def update_failed_jobs_and_send_logs(
    api_instance,
    core_v1_api_instance,
    evalai,
    job_name,
    Severity: Minor
    Found in scripts/workers/code_upload_submission_worker.py - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function main has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

    def main():
    killer = GracefulKiller()
    evalai = EvalAI_Interface(
        AUTH_TOKEN=AUTH_TOKEN,
        EVALAI_API_SERVER=EVALAI_API_SERVER,
    Severity: Minor
    Found in scripts/workers/code_upload_submission_worker.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create_static_code_upload_submission_job_object has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def create_static_code_upload_submission_job_object(message, challenge):
    """Function to create the static code upload pod AWS EKS Job object

    Arguments:
        message {[dict]} -- Submission message from AWS SQS queue
    Severity: Minor
    Found in scripts/workers/code_upload_submission_worker.py - About 1 hr to fix

      Function update_failed_jobs_and_send_logs has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def update_failed_jobs_and_send_logs(
      Severity: Major
      Found in scripts/workers/code_upload_submission_worker.py - About 1 hr to fix

        Function cleanup_submission has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def cleanup_submission(
        Severity: Major
        Found in scripts/workers/code_upload_submission_worker.py - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                  if container_name in ["agent", "submission", "environment"]:
                            if container_state.terminated is not None:
                                pod_name = pods_list.items[0].metadata.name
                                try:
                                    pod_log_response = core_v1_api_instance.read_namespaced_pod_log(
          Severity: Major
          Found in scripts/workers/code_upload_submission_worker.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if job_name:
                            latest_job_name = job_name[-1]
                            delete_job(api_instance, latest_job_name)
                        else:
                            logger.info(
            Severity: Major
            Found in scripts/workers/code_upload_submission_worker.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if pods_list and pods_list.items[0].status.container_statuses:
                        # Update submission to running
                        submission_data = {
                            "submission_status": "running",
                            "submission": submission_pk,
              Severity: Major
              Found in scripts/workers/code_upload_submission_worker.py - About 45 mins to fix

                Function process_submission_callback has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def process_submission_callback(api_instance, body, challenge_phase, challenge, evalai):
                Severity: Minor
                Found in scripts/workers/code_upload_submission_worker.py - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def get_core_v1_api_object(cluster_name, cluster_endpoint, challenge, evalai):
    configuration = client.Configuration()
    aws_eks_api = evalai.get_aws_eks_bearer_token(challenge.get("id"))
    configuration.host = cluster_endpoint
    configuration.verify_ssl = True
                  Severity: Major
                  Found in scripts/workers/code_upload_submission_worker.py and 1 other location - About 6 hrs to fix
                  scripts/workers/code_upload_submission_worker.py on lines 460..471

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 108.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def get_api_object(cluster_name, cluster_endpoint, challenge, evalai):
    configuration = client.Configuration()
    aws_eks_api = evalai.get_aws_eks_bearer_token(challenge.get("id"))
    configuration.host = cluster_endpoint
    configuration.verify_ssl = True
                  Severity: Major
                  Found in scripts/workers/code_upload_submission_worker.py and 1 other location - About 6 hrs to fix
                  scripts/workers/code_upload_submission_worker.py on lines 488..499

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 108.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status