Sign upLogin

CloudHealth/amazon-pricing

View on GitHub
Star

Showing 77 of 77 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          case val['name']
          when "yrTerm1", "yrTerm1Standard"
            cache.set_prepay(type_of_instance, :year1, price)
          when "yrTerm3", "yrTerm3Standard"
            cache.set_prepay(type_of_instance, :year3, price)
Severity: Major
Found in lib/amazon-pricing/definitions/elasticache_node_type.rb and 1 other location - About 1 hr to fix
lib/amazon-pricing/definitions/ec2-instance-type.rb on lines 77..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method populate_lookups has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def self.populate_lookups
      # We use Linux on-demand to populate the lookup tables with the basic lookup information
      ["http://a0.awsstatic.com/pricing/1/ec2/linux-od.min.js", "http://a0.awsstatic.com/pricing/1/ec2/previous-generation/linux-od.min.js"].each do |url|
        res = AwsPricing::PriceList.fetch_url(url)
Severity: Minor
Found in lib/amazon-pricing/definitions/instance-type.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_od_price_if_missing has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def set_od_price_if_missing(region, region_name, api_name, operating_system, instance_type, type_json)
      type_json["terms"].each do |term|
        # handle case of ondemand pricing missing;  turns out od-pricing is also in ri-pricing
        # (assumes od pricing has been set, iff both api_name+os are available)
        if not region.instance_type_available?(api_name, :ondemand, operating_system)
Severity: Minor
Found in lib/amazon-pricing/common/ec2_common.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_pricing2 has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def update_pricing2(operating_system, res_type, ondemand_pph = nil, year1_prepay = nil, year3_prepay = nil, year1_pph = nil, year3_pph = nil)
Severity: Major
Found in lib/amazon-pricing/definitions/ec2-instance-type.rb - About 50 mins to fix

    Method update_pricing_new has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_pricing_new(operating_system, type_of_instance, price, term = nil, is_prepay = false)
      os = get_category_type(operating_system)
      if os.nil?
        os = OperatingSystem.new(self, operating_system)
        @category_types[operating_system] = os
    Severity: Minor
    Found in lib/amazon-pricing/definitions/ec2-instance-type.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method set_od_price_if_missing has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def set_od_price_if_missing(region, region_name, api_name, operating_system, instance_type, type_json)
    Severity: Minor
    Found in lib/amazon-pricing/common/ec2_common.rb - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if db == :oracle
                  fetch_reserved_rds_instance_pricing(RDS_BASE_URL+"#{db}/pricing-#{dp_type}-#{res_type}-utilization-reserved-instances.min.js", res_type, db_type, is_byol)
                elsif db == :sqlserver
                  fetch_reserved_rds_instance_pricing(RDS_BASE_URL+"#{db}/sqlserver-#{dp_type}-#{res_type}-ri.min.js", res_type, db_type, is_byol)
                end
      Severity: Minor
      Found in lib/amazon-pricing/rds-price-list.rb and 1 other location - About 45 mins to fix
      lib/amazon-pricing/rds-price-list.rb on lines 242..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if db == :oracle
                  fetch_reserved_rds_instance_pricing(RDS_BASE_URL+"#{db}/previous-generation/pricing-#{dp_type}-#{res_type}-utilization-reserved-instances.min.js", res_type, db_type, is_byol)
                elsif db == :sqlserver
                  fetch_reserved_rds_instance_pricing(RDS_BASE_URL+"#{db}/previous-generation/sqlserver-#{dp_type}-#{res_type}-ri.min.js", res_type, db_type, is_byol)
                end
      Severity: Minor
      Found in lib/amazon-pricing/rds-price-list.rb and 1 other location - About 45 mins to fix
      lib/amazon-pricing/rds-price-list.rb on lines 235..239

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method update_pricing_new has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def update_pricing_new(database_type, type_of_instance, prices, term = nil, is_multi_az, is_byol)
      Severity: Minor
      Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 45 mins to fix

        Method fetch_ec2_dedicated_host_pricing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def fetch_ec2_dedicated_host_pricing(url, operating_system)
      res = PriceList.fetch_url(url)
      begin
        res['config']['regions'].each do |reg|
          region_name = reg['region']
        Severity: Minor
        Found in lib/amazon-pricing/ec2-dh-price-list.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method update_pricing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def update_pricing(operating_system, type_of_instance, json)
      os = get_category_type(operating_system)
      if os.nil?
        os = OperatingSystem.new(self, operating_system)
        @category_types[operating_system] = os
        Severity: Minor
        Found in lib/amazon-pricing/definitions/ec2-instance-type.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if db == :postgresql and res_type == :heavy
              fetch_reserved_rds_instance_pricing(RDS_BASE_URL+"#{db}/pricing-#{res_type}-utilization-reserved-instances.min.js", res_type, db, false)
            elsif db == :mysql
              fetch_reserved_rds_instance_pricing(RDS_BASE_URL+"#{db}/pricing-#{res_type}-utilization-reserved-instances.min.js", res_type, db, false)
            end
        Severity: Minor
        Found in lib/amazon-pricing/rds-price-list.rb and 1 other location - About 40 mins to fix
        lib/amazon-pricing/rds-price-list.rb on lines 224..228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if db == :postgresql and res_type == :heavy
              fetch_reserved_rds_instance_pricing(RDS_BASE_URL+"#{db}/previous-generation/pricing-#{res_type}-utilization-reserved-instances.min.js", res_type, db, false)
            elsif db == :mysql
              fetch_reserved_rds_instance_pricing(RDS_BASE_URL+"#{db}/previous-generation/pricing-#{res_type}-utilization-reserved-instances.min.js", res_type, db, false)
            end
        Severity: Minor
        Found in lib/amazon-pricing/rds-price-list.rb and 1 other location - About 40 mins to fix
        lib/amazon-pricing/rds-price-list.rb on lines 217..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method price_per_hour has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def price_per_hour(category_type, type_of_instance, term = nil, is_multi_az = false, isByol = false)
        Severity: Minor
        Found in lib/amazon-pricing/definitions/instance-type.rb - About 35 mins to fix

          Method update_pricing has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def update_pricing(database_type, type_of_instance, json, is_multi_az, is_byol)
          Severity: Minor
          Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 35 mins to fix

            Method update_pricing_new has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def update_pricing_new(operating_system, type_of_instance, price, term = nil, is_prepay = false)
            Severity: Minor
            Found in lib/amazon-pricing/definitions/ec2-instance-type.rb - About 35 mins to fix

              Method get_breakeven_month has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def get_breakeven_month(category_types, type_of_instance, term, is_multi_az = false, isByol = false)
              Severity: Minor
              Found in lib/amazon-pricing/definitions/instance-type.rb - About 35 mins to fix

                Method ensure_existence_of_instance_type has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def ensure_existence_of_instance_type(region, region_name, api_name, operating_system, type_json)
                Severity: Minor
                Found in lib/amazon-pricing/common/ec2_common.rb - About 35 mins to fix

                  Method fetch_on_demand_rds_instance_pricing has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def fetch_on_demand_rds_instance_pricing(url, type_of_rds_instance, db_type, is_byol, is_multi_az = false)
                  Severity: Minor
                  Found in lib/amazon-pricing/rds-price-list.rb - About 35 mins to fix

                    Method prepay has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def prepay(category_type, type_of_instance, term = nil, is_multi_az = false, isByol = false)
                    Severity: Minor
                    Found in lib/amazon-pricing/definitions/instance-type.rb - About 35 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language