Sign upLogin

CloudHealth/amazon-pricing

View on GitHub
Star
lib/amazon-pricing/definitions/category-type.rb

Summary

Maintainability
D
2 days
Test Coverage

Method set_prepay has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def set_prepay(type_of_instance, term, price)
      case type_of_instance
      when :light
        if term == :year1
          @light_prepay_1_year = price
Severity: Minor
Found in lib/amazon-pricing/definitions/category-type.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_price_per_hour has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def set_price_per_hour(type_of_instance, term, price_per_hour)
      case type_of_instance
      when :ondemand
        @ondemand_price_per_hour = price_per_hour
      when :light
Severity: Minor
Found in lib/amazon-pricing/definitions/category-type.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method price_per_hour has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def price_per_hour(type_of_instance = :ondemand, term = nil)
      case type_of_instance
      when :ondemand
        @ondemand_price_per_hour
      when :light
Severity: Minor
Found in lib/amazon-pricing/definitions/category-type.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method prepay has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def prepay(type_of_instance = :ondemand, term = nil)
      case type_of_instance
      when :ondemand
        0
      when :light
Severity: Minor
Found in lib/amazon-pricing/definitions/category-type.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method price_per_hour has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def price_per_hour(type_of_instance = :ondemand, term = nil)
      case type_of_instance
      when :ondemand
        @ondemand_price_per_hour
      when :light
Severity: Minor
Found in lib/amazon-pricing/definitions/category-type.rb - About 1 hr to fix

    Method prepay has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def prepay(type_of_instance = :ondemand, term = nil)
      case type_of_instance
      when :ondemand
        0
      when :light
    Severity: Minor
    Found in lib/amazon-pricing/definitions/category-type.rb - About 1 hr to fix

      Method set_prepay has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def set_prepay(type_of_instance, term, price)
      case type_of_instance
      when :light
        if term == :year1
          @light_prepay_1_year = price
      Severity: Minor
      Found in lib/amazon-pricing/definitions/category-type.rb - About 1 hr to fix

        Method set_price_per_hour has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def set_price_per_hour(type_of_instance, term, price_per_hour)
      case type_of_instance
      when :ondemand
        @ondemand_price_per_hour = price_per_hour
      when :light
        Severity: Minor
        Found in lib/amazon-pricing/definitions/category-type.rb - About 1 hr to fix

          Method get_breakeven_month has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def get_breakeven_month(type_of_instance, term)
      # Some regions and types do not have reserved available
      ondemand_pph = price_per_hour(:ondemand)
      reserved_pph = price_per_hour(type_of_instance, term)
      return nil if ondemand_pph.nil? || reserved_pph.nil?
          Severity: Minor
          Found in lib/amazon-pricing/definitions/category-type.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                when :partialupfront
        if term == :year1
          @partialupfront_prepay_1_year = price
        elsif term == :year1_convertible
          @convertible_partialupfront_prepay_1_year = price
          Severity: Minor
          Found in lib/amazon-pricing/definitions/category-type.rb and 3 other locations - About 20 mins to fix
          lib/amazon-pricing/definitions/category-type.rb on lines 127..136
          lib/amazon-pricing/definitions/category-type.rb on lines 225..234
          lib/amazon-pricing/definitions/category-type.rb on lines 235..244

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                when :allupfront
        if term == :year1
          @allupfront_prepay_1_year = price
        elsif term == :year1_convertible
          @convertible_allupfront_prepay_1_year = price
          Severity: Minor
          Found in lib/amazon-pricing/definitions/category-type.rb and 3 other locations - About 20 mins to fix
          lib/amazon-pricing/definitions/category-type.rb on lines 137..146
          lib/amazon-pricing/definitions/category-type.rb on lines 225..234
          lib/amazon-pricing/definitions/category-type.rb on lines 235..244

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                when :partialupfront
        if term == :year1
          @partialupfront_price_per_hour_1_year = price_per_hour
        elsif term == :year1_convertible
          @convertible_partialupfront_price_per_hour_1_year = price_per_hour
          Severity: Minor
          Found in lib/amazon-pricing/definitions/category-type.rb and 3 other locations - About 20 mins to fix
          lib/amazon-pricing/definitions/category-type.rb on lines 127..136
          lib/amazon-pricing/definitions/category-type.rb on lines 137..146
          lib/amazon-pricing/definitions/category-type.rb on lines 235..244

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                when :noupfront
        if term == :year1
          @noupfront_price_per_hour_1_year = price_per_hour
        elsif term == :year1_convertible
          @convertible_noupfront_price_per_hour_1_year = price_per_hour
          Severity: Minor
          Found in lib/amazon-pricing/definitions/category-type.rb and 3 other locations - About 20 mins to fix
          lib/amazon-pricing/definitions/category-type.rb on lines 127..136
          lib/amazon-pricing/definitions/category-type.rb on lines 137..146
          lib/amazon-pricing/definitions/category-type.rb on lines 225..234

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status