Method update_pricing2 has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def update_pricing2(operating_system, res_type, ondemand_pph = nil, year1_prepay = nil, year3_prepay = nil, year1_pph = nil, year3_pph = nil)
os = get_category_type(operating_system)
if os.nil?
os = OperatingSystem.new(self, operating_system)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_pricing has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update_pricing(operating_system, type_of_instance, json)
os = get_category_type(operating_system)
if os.nil?
os = OperatingSystem.new(self, operating_system)
@category_types[operating_system] = osMethod update_pricing_new has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update_pricing_new(operating_system, type_of_instance, price, term = nil, is_prepay = false)
os = get_category_type(operating_system)
if os.nil?
os = OperatingSystem.new(self, operating_system)
@category_types[operating_system] = osMethod update_pricing2 has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_pricing2(operating_system, res_type, ondemand_pph = nil, year1_prepay = nil, year3_prepay = nil, year1_pph = nil, year3_pph = nil)Method update_pricing_new has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def update_pricing_new(operating_system, type_of_instance, price, term = nil, is_prepay = false)
os = get_category_type(operating_system)
if os.nil?
os = OperatingSystem.new(self, operating_system)
@category_types[operating_system] = os- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_pricing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def update_pricing(operating_system, type_of_instance, json)
os = get_category_type(operating_system)
if os.nil?
os = OperatingSystem.new(self, operating_system)
@category_types[operating_system] = os- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_pricing_new has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_pricing_new(operating_system, type_of_instance, price, term = nil, is_prepay = false)Similar blocks of code found in 2 locations. Consider refactoring. Open
case val["name"]
when "yrTerm1", "yrTerm1Standard"
os.set_prepay(type_of_instance, :year1, price)
when "yrTerm3", "yrTerm3Standard"
os.set_prepay(type_of_instance, :year3, price)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 48.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
def self.get_name(instance_type, api_name, is_reserved = false)
# Temporary hack: Amazon has released r3 instances but pricing has api_name with asterisk (e.g. "r3.large *")
api_name.sub!(" *", "")
# Let's handle new instances more gracefully- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 29.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76