Sign upLogin

CloudHealth/amazon-pricing

View on GitHub
Star
lib/amazon-pricing/definitions/rds-instance-type.rb

Summary

Maintainability
D
2 days
Test Coverage

Method update_pricing_new has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def update_pricing_new(database_type, type_of_instance, prices, term = nil, is_multi_az, is_byol)
      db = get_category_type(database_type, is_multi_az, is_byol)
      if db.nil?
        db = DatabaseType.new(self, database_type)
Severity: Minor
Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_pricing has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    def update_pricing(database_type, type_of_instance, json, is_multi_az, is_byol)
      db = get_category_type(database_type, is_multi_az, is_byol)
      if db.nil?
        db = DatabaseType.new(self, database_type)
Severity: Minor
Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_pricing2 has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def update_pricing2(database_type, type_of_instance, is_multi_az, is_byol, ondemand_pph = nil, year1_prepay = nil, year3_prepay = nil, year1_pph = nil, year3_pph = nil)
      db = get_category_type(database_type, is_multi_az, is_byol)
      if db.nil?
        db = DatabaseType.new(self, database_type)
Severity: Minor
Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_pricing has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def update_pricing(database_type, type_of_instance, json, is_multi_az, is_byol)
      db = get_category_type(database_type, is_multi_az, is_byol)
      if db.nil?
        db = DatabaseType.new(self, database_type)
Severity: Minor
Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 2 hrs to fix

    Method update_pricing_new has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def update_pricing_new(database_type, type_of_instance, prices, term = nil, is_multi_az, is_byol)
      db = get_category_type(database_type, is_multi_az, is_byol)
      if db.nil?
        db = DatabaseType.new(self, database_type)
    Severity: Minor
    Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 1 hr to fix

      Method update_pricing2 has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def update_pricing2(database_type, type_of_instance, is_multi_az, is_byol, ondemand_pph = nil, year1_prepay = nil, year3_prepay = nil, year1_pph = nil, year3_pph = nil)
      Severity: Major
      Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 1 hr to fix

        Method update_pricing_new has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def update_pricing_new(database_type, type_of_instance, prices, term = nil, is_multi_az, is_byol)
        Severity: Minor
        Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 45 mins to fix

          Method update_pricing has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def update_pricing(database_type, type_of_instance, json, is_multi_az, is_byol)
          Severity: Minor
          Found in lib/amazon-pricing/definitions/rds-instance-type.rb - About 35 mins to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                  if db.nil?
        db = DatabaseType.new(self, database_type)        

        if is_multi_az == true and is_byol == true
          @category_types["#{database_type}_byol_multiaz"] = db
            Severity: Major
            Found in lib/amazon-pricing/definitions/rds-instance-type.rb and 2 other locations - About 1 hr to fix
            lib/amazon-pricing/definitions/rds-instance-type.rb on lines 100..111
            lib/amazon-pricing/definitions/rds-instance-type.rb on lines 149..160

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                  if db.nil?
        db = DatabaseType.new(self, database_type)

        if is_multi_az == true and is_byol == true
          @category_types["#{database_type}_byol_multiaz"] = db
            Severity: Major
            Found in lib/amazon-pricing/definitions/rds-instance-type.rb and 2 other locations - About 1 hr to fix
            lib/amazon-pricing/definitions/rds-instance-type.rb on lines 36..47
            lib/amazon-pricing/definitions/rds-instance-type.rb on lines 149..160

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                  if db.nil?
        db = DatabaseType.new(self, database_type)        
        
        if is_multi_az == true and is_byol == true
          @category_types["#{database_type}_byol_multiaz"] = db
            Severity: Major
            Found in lib/amazon-pricing/definitions/rds-instance-type.rb and 2 other locations - About 1 hr to fix
            lib/amazon-pricing/definitions/rds-instance-type.rb on lines 36..47
            lib/amazon-pricing/definitions/rds-instance-type.rb on lines 100..111

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status