Sign upLogin

CloudSlang/cloud-slang

View on GitHub
Star

Showing 462 of 462 total issues

File ExecutableBuilder.java has 765 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
Severity: Major
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/modeller/ExecutableBuilder.java - About 1 day to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    def validate_input(input_value, parameter_name, default_value):
    if type(input_value).__name__ == "NoneType":
        return default_value
    elif type(input_value).__name__ == "int":
        return input_value
    Severity: Major
    Found in cloudslang-runtime/src/main/resources/scripts/cs_substring.py and 2 other locations - About 1 day to fix
    cloudslang-runtime/src/main/resources/scripts/cs_extract_number.py on lines 18..31
    cloudslang-runtime/src/main/resources/scripts/cs_replace.py on lines 21..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    def validate_input(input_value, parameter_name, default_value):
    if type(input_value).__name__ == "NoneType":
        return default_value
    elif type(input_value).__name__ == "int":
        return input_value
    Severity: Major
    Found in cloudslang-runtime/src/main/resources/scripts/cs_replace.py and 2 other locations - About 1 day to fix
    cloudslang-runtime/src/main/resources/scripts/cs_extract_number.py on lines 18..31
    cloudslang-runtime/src/main/resources/scripts/cs_substring.py on lines 18..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    def validate_input(input_value, parameter_name, default_value):
    if type(input_value).__name__ == "NoneType":
        return default_value
    elif type(input_value).__name__ == "int":
        return input_value
    Severity: Major
    Found in cloudslang-runtime/src/main/resources/scripts/cs_extract_number.py and 2 other locations - About 1 day to fix
    cloudslang-runtime/src/main/resources/scripts/cs_replace.py on lines 21..34
    cloudslang-runtime/src/main/resources/scripts/cs_substring.py on lines 18..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File SlangBuildMain.java has 568 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
    Severity: Major
    Found in cloudslang-content-verifier/src/main/java/io/cloudslang/lang/tools/build/SlangBuildMain.java - About 1 day to fix

      File PreCompileValidatorImpl.java has 523 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
      Severity: Major
      Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/validator/PreCompileValidatorImpl.java - About 1 day to fix

        File SlangTestRunner.java has 499 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
        Severity: Minor
        Found in cloudslang-content-verifier/src/main/java/io/cloudslang/lang/tools/build/tester/SlangTestRunner.java - About 1 day to fix

          SlangCompilerSpringConfig has 53 methods (exceeds 20 allowed). Consider refactoring.
          Open

          @Configuration
@ComponentScan("io.cloudslang.lang.compiler")
@Import(SlangEntitiesSpringConfig.class)
public class SlangCompilerSpringConfig {
          Severity: Major
          Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/configuration/SlangCompilerSpringConfig.java - About 7 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Severity: Major
            Found in cloudslang-runtime/src/main/resources/scripts/cs_prepend.py and 1 other location - About 7 hrs to fix
            cloudslang-runtime/src/main/resources/scripts/cs_append.py on lines 0..9

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 116.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Severity: Major
            Found in cloudslang-runtime/src/main/resources/scripts/cs_append.py and 1 other location - About 7 hrs to fix
            cloudslang-runtime/src/main/resources/scripts/cs_prepend.py on lines 0..9

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 116.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method transformToExecutable has 160 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public ExecutableModellingResult transformToExecutable(ParsedSlang parsedSlang,
                                                           Map<String, Object> executableRawData,
                                                           SensitivityLevel sensitivityLevel) {
        List<RuntimeException> errors = new ArrayList<>();
        String execName = preCompileValidator.validateExecutableRawData(parsedSlang, executableRawData, errors);
            Severity: Major
            Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/modeller/ExecutableBuilder.java - About 6 hrs to fix

              File SlangCompilerImpl.java has 421 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
              Severity: Minor
              Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 6 hrs to fix

                File ExecutableExecutionData.java has 417 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
                Severity: Minor
                Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/steps/ExecutableExecutionData.java - About 6 hrs to fix

                  File AbstractExecutionData.java has 403 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
                  Severity: Minor
                  Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/steps/AbstractExecutionData.java - About 5 hrs to fix

                    ExecutableBuilder has 42 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    public class ExecutableBuilder {

    public static final String UNIQUE_STEP_NAME_MESSAGE_SUFFIX = "Each step name in the workflow must be unique";

    private List<Transformer> transformers;
                    Severity: Minor
                    Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/modeller/ExecutableBuilder.java - About 5 hrs to fix

                      File SlangCompilerSpringConfig.java has 400 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
                      Severity: Minor
                      Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/configuration/SlangCompilerSpringConfig.java - About 5 hrs to fix

                        LanguageEventData has 39 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        @SuppressWarnings("unchecked")
public class LanguageEventData extends HashMap<String, Serializable> {

    public static final String TYPE = "TYPE";
    public static final String DESCRIPTION = "DESCRIPTION";
                        Severity: Minor
                        Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/events/LanguageEventData.java - About 5 hrs to fix

                          Method main has 129 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public static void main(String[] args) {
        loadUserProperties();
        configureLog4j();

        ApplicationArgs appArgs = new ApplicationArgs();
                          Severity: Major
                          Found in cloudslang-content-verifier/src/main/java/io/cloudslang/lang/tools/build/SlangBuildMain.java - About 5 hrs to fix

                            Method compileWorkFlow has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private WorkflowModellingResult compileWorkFlow(List<Map<String, Map<String, Object>>> workFlowRawData,
                                                    Map<String, String> imports,
                                                    Workflow onFailureWorkFlow,
                                                    boolean onFailureSection,
                                                    String namespace,
                            Severity: Minor
                            Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/modeller/ExecutableBuilder.java - About 5 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            File ParallelLoopExecutionData.java has 374 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            /*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
                            Severity: Minor
                            Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/steps/ParallelLoopExecutionData.java - About 5 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language