Sign upLogin

CloudSlang/cloud-slang

View on GitHub
Star

Showing 132 of 463 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

public enum SlangSystemPropertyConstant {
    CSLANG_ENCODING("cslang.encoding"),
    LOG4J_CONFIGURATION("log4j.configuration"),
    CSLANG_RUNTIME_EVENTS_VERBOSITY("cslang.runtime.events.verbosity");
Severity: Minor
Found in cloudslang-entities/src/main/java/io/cloudslang/lang/entities/properties/SlangSystemPropertyConstant.java and 1 other location - About 30 mins to fix
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/modeller/transformers/Transformer.java on lines 51..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    enum Type {
        INTERNAL("internal"),
        EXTERNAL("external"),
        BOTH("both");
Severity: Minor
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/modeller/transformers/Transformer.java and 1 other location - About 30 mins to fix
cloudslang-entities/src/main/java/io/cloudslang/lang/entities/properties/SlangSystemPropertyConstant.java on lines 12..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private Iterable<Value> convert(Iterable<? extends Serializable> iterable, boolean sensitive) {
        List<Value> values = new ArrayList<>();
        for (Serializable serializable : iterable) {
            values.add(ValueFactory.create(serializable, sensitive));
        }
Severity: Minor
Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/AbstractBinding.java and 1 other location - About 30 mins to fix
cloudslang-content-verifier/src/main/java/io/cloudslang/lang/tools/build/tester/parse/TestCasesYamlParser.java on lines 115..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private List<Map> getInputs(List<Map<String, Serializable>> inputsList, String artifact) {
        List<Map> inputs = new ArrayList<>();
        for (Map<String, Serializable> singleElementInputMap : inputsList) {
            inputs.add(slangSourceService.convertInputFromMap(singleElementInputMap, artifact));
        }
Severity: Minor
Found in cloudslang-content-verifier/src/main/java/io/cloudslang/lang/tools/build/tester/parse/TestCasesYamlParser.java and 1 other location - About 30 mins to fix
cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/AbstractBinding.java on lines 101..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                if (variableLine) {
                    Pair<String, String> declaration =
                            descriptionPatternMatcher.getDescriptionVariableLineData(currentLine);
                    String[] declarationElements = descriptionPatternMatcher.splitDeclaration(declaration.getLeft());
                    currentTag = declarationElements[0];
Severity: Minor
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java and 2 other locations - About 30 mins to fix
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 103..108
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 98..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        for (Map.Entry<String, Value> entry : valueMap.entrySet()) {
            result.put(entry.getKey(), entry.getValue() == null ? null : entry.getValue().toString());
        }
Severity: Minor
Found in cloudslang-entities/src/main/java/io/cloudslang/lang/entities/utils/ValueUtils.java and 2 other locations - About 30 mins to fix
cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/steps/ActionExecutionData.java on lines 255..257
cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/steps/ParallelLoopExecutionData.java on lines 445..447

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        for (Map.Entry<String, Value> entry : map.entrySet()) {
            result.put(entry.getKey(), entry.getValue() == null ? null : entry.getValue().get());
        }
Severity: Minor
Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/steps/ParallelLoopExecutionData.java and 2 other locations - About 30 mins to fix
cloudslang-entities/src/main/java/io/cloudslang/lang/entities/utils/ValueUtils.java on lines 49..51
cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/steps/ActionExecutionData.java on lines 255..257

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                } else {
                    Pair<String, String> declaration =
                            descriptionPatternMatcher.getDescriptionVariableLineDataDeclarationOnly(currentLine);
                    String[] declarationElements = descriptionPatternMatcher.splitDeclaration(declaration.getLeft());
                    currentTag = declarationElements[0];
Severity: Minor
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java and 2 other locations - About 30 mins to fix
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 98..103
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 93..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                } else if (isGeneralLine) {
                    Pair<String, String> declaration =
                            descriptionPatternMatcher.getDescriptionGeneralLineData(currentLine);
                    String[] declarationElements = descriptionPatternMatcher.splitDeclaration(declaration.getLeft());
                    currentTag = declarationElements[0];
Severity: Minor
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java and 2 other locations - About 30 mins to fix
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 103..108
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 93..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public Pair<String, String> getDescriptionGeneralLineData(String input) {
        List<String> matches = getData(
                descriptionGeneralLinePattern,
                input,
                Regex.DESCRIPTION_GENERAL_LINE_DECLARATION_GROUP_NR,
Severity: Minor
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/validator/matcher/DescriptionPatternMatcher.java and 1 other location - About 30 mins to fix
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/validator/matcher/DescriptionPatternMatcher.java on lines 110..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        for (Map.Entry<String, Value> entry : context.entrySet()) {
            result.put(entry.getKey(), entry.getValue() == null ? null : entry.getValue().get());
        }
Severity: Minor
Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/steps/ActionExecutionData.java and 2 other locations - About 30 mins to fix
cloudslang-entities/src/main/java/io/cloudslang/lang/entities/utils/ValueUtils.java on lines 49..51
cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/steps/ParallelLoopExecutionData.java on lines 445..447

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public Pair<String, String> getDescriptionVariableLineData(String input) {
        List<String> matches = getData(
                descriptionVariableLinePattern,
                input,
                Regex.DESCRIPTION_VARIABLE_LINE_DECLARATION_GROUP_NR,
Severity: Minor
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/validator/matcher/DescriptionPatternMatcher.java and 1 other location - About 30 mins to fix
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/validator/matcher/DescriptionPatternMatcher.java on lines 129..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language