File AbbyyApi.java
has 327 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
* Copyright 2020-2024 Open Text
* This program and the accompanying materials
* are made available under the terms of the Apache License v2.0 which accompany this distribution.
*
Method getResultChunk
has 63 lines of code (exceeds 25 allowed). Consider refactoring. Open
public String getResultChunk(@NotNull AbbyyInput abbyyInput, @NotNull String resultUrl, @NotNull ExportFormat exportFormat,
int startByteIndex, int endByteIndex) throws AbbyySdkException, IOException, HttpClientException, URISyntaxException {
if (startByteIndex < 0) {
throw new IllegalArgumentException(String.format(ExceptionMsgs.NEGATIVE_NUMBER, "startByteIndex"));
}
Method getResultSize
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
public long getResultSize(@NotNull AbbyyInput abbyyInput, @NotNull String resultUrl, @NotNull ExportFormat exportFormat)
throws AbbyySdkException, IOException, HttpClientException, URISyntaxException {
HttpRequest httpRequest = new HttpClientRequest.Builder()
.url(resultUrl)
Method getTaskStatus
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
public AbbyyResponse getTaskStatus(@NotNull AbbyyInput abbyyInput, @NotNull String taskId) throws Exception {
String url = new URIBuilder()
.setScheme(abbyyInput.getLocationId().getProtocol())
.setHost(String.format(Urls.HOST_TEMPLATE, abbyyInput.getLocationId(), Endpoints.GET_TASK_STATUS))
.addParameter(QueryParams.TASK_ID, taskId)
Method getResult
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public String getResult(@NotNull AbbyyInput abbyyInput, @NotNull String resultUrl, @NotNull ExportFormat exportFormat,
@Nullable String downloadPath, boolean useSpecificCharSet) throws AbbyySdkException, IOException, HttpClientException, URISyntaxException {
HttpRequest httpRequest = new HttpClientRequest.Builder()
.url(resultUrl)
.tlsVersion(abbyyInput.getTlsVersion())
Method request
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public AbbyyResponse request(@NotNull AbbyyInput abbyyInput) throws Exception {
HttpRequest httpRequest = new HttpClientRequest.Builder()
.url(abbyyInput.getUrl())
.tlsVersion(abbyyInput.getTlsVersion())
Method getResultChunk
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public String getResultChunk(@NotNull AbbyyInput abbyyInput, @NotNull String resultUrl, @NotNull ExportFormat exportFormat,
int startByteIndex, int endByteIndex) throws AbbyySdkException, IOException, HttpClientException, URISyntaxException {
Method getResult
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public String getResult(@NotNull AbbyyInput abbyyInput, @NotNull String resultUrl, @NotNull ExportFormat exportFormat,
@Nullable String downloadPath, boolean useSpecificCharSet) throws AbbyySdkException, IOException, HttpClientException, URISyntaxException {
Identical blocks of code found in 2 locations. Consider refactoring. Open
HttpRequest httpRequest = new HttpClientRequest.Builder()
.url(resultUrl)
.tlsVersion(abbyyInput.getTlsVersion())
.allowedCyphers(abbyyInput.getAllowedCyphers())
.authType(Headers.AUTH_TYPE_ANONYMOUS)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 162.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
HttpRequest httpRequest = new HttpClientRequest.Builder()
.url(resultUrl)
.tlsVersion(abbyyInput.getTlsVersion())
.allowedCyphers(abbyyInput.getAllowedCyphers())
.authType(Headers.AUTH_TYPE_ANONYMOUS)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 162.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76