CloudSlang/cs-actions

View on GitHub
cs-alibaba/src/main/java/io/cloudslang/content/alibaba/services/InstanceService.java

Summary

Maintainability
D
1 day
Test Coverage

Method createInstance has 40 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public static String createInstance(final String proxyHost,
                                        final String proxyPort,
                                        final String proxyUsername,
                                        final String proxyPassword,
                                        final String regionId,

    Method createInstance has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static String createInstance(final String proxyHost,
                                            final String proxyPort,
                                            final String proxyUsername,
                                            final String proxyPassword,
                                            final String regionId,

      Method stopInstance has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static String stopInstance(final String proxyHost,
                                            final String proxyPort,
                                            final String proxyUsername,
                                            final String proxyPassword,
                                            final String instanceId,

        Method getInstanceStatus has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static String getInstanceStatus(final String proxyHost,
                                                   final String proxyPort,
                                                   final String proxyUsername,
                                                   final String proxyPassword,
                                                   final String instanceId,

          Method restartInstance has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static String restartInstance(final String proxyHost,
                                                   final String proxyPort,
                                                   final String proxyUsername,
                                                   final String proxyPassword,
                                                   final String instanceId,

            Method startInstance has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static String startInstance(final String proxyHost,
                                                   final String proxyPort,
                                                   final String proxyUsername,
                                                   final String proxyPassword,
                                                   final String instanceId,

              Method deleteInstance has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static String deleteInstance(final String proxyHost,
                                                      final String proxyPort,
                                                      final String proxyUsername,
                                                      final String proxyPassword,
                                                      final String instanceId,

                Method getResponse has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    private static AcsResponse getResponse(final String proxyHost,
                                                           final String proxyPort,
                                                           final String proxyUsername,
                                                           final String proxyPassword,
                                                           final IAcsClient client,

                  Method allocatePublicIpAddress has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public static String allocatePublicIpAddress(final String proxyHost,
                                                                   final String proxyPort,
                                                                   final String proxyUsername,
                                                                   final String proxyPassword,
                                                                   final String instanceId,

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public static String restartInstance(final String proxyHost,
                                                             final String proxyPort,
                                                             final String proxyUsername,
                                                             final String proxyPassword,
                                                             final String instanceId,
                    cs-alibaba/src/main/java/io/cloudslang/content/alibaba/services/InstanceService.java on lines 171..186

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public static String startInstance(final String proxyHost,
                                                           final String proxyPort,
                                                           final String proxyUsername,
                                                           final String proxyPassword,
                                                           final String instanceId,
                    cs-alibaba/src/main/java/io/cloudslang/content/alibaba/services/InstanceService.java on lines 210..225

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public static String allocatePublicIpAddress(final String proxyHost,
                                                                     final String proxyPort,
                                                                     final String proxyUsername,
                                                                     final String proxyPassword,
                                                                     final String instanceId,
                    cs-alibaba/src/main/java/io/cloudslang/content/alibaba/services/InstanceService.java on lines 116..129

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public static String deleteInstance(final String proxyHost,
                                                            final String proxyPort,
                                                            final String proxyUsername,
                                                            final String proxyPassword,
                                                            final String instanceId,
                    cs-alibaba/src/main/java/io/cloudslang/content/alibaba/services/InstanceService.java on lines 131..144

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status