Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java

Summary

Maintainability
D
2 days
Test Coverage

Method createVMRequestBody has 147 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static String createVMRequestBody(@NotNull final AzureCreateVMInputs inputs) throws Exception {
        CreateVMRequestBody createVMRequestBody = new CreateVMRequestBody();
        createVMRequestBody.setLocation(inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getLocation());
        createVMRequestBody.setId(SUBSCRIPTION_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getSubscriptionId() +
                RESOURCE_GROUPS_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getResourceGroupName() + AZURE_CREATE_VM_PATH +
Severity: Major
Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java - About 5 hrs to fix

    File AzureComputeImpl.java has 347 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright 2024 Open Text
 * This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
    Severity: Minor
    Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java - About 4 hrs to fix

      Method createVMRequestBody has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          private static String createVMRequestBody(@NotNull final AzureCreateVMInputs inputs) throws Exception {
        CreateVMRequestBody createVMRequestBody = new CreateVMRequestBody();
        createVMRequestBody.setLocation(inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getLocation());
        createVMRequestBody.setId(SUBSCRIPTION_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getSubscriptionId() +
                RESOURCE_GROUPS_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getResourceGroupName() + AZURE_CREATE_VM_PATH +
      Severity: Minor
      Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              StringBuilder pathString = new StringBuilder()
                .append(azureCreateVMInputs.getAzureComputeCommonInputs().getAzureProtocol())
                .append(AZURE_PROTOCOL_PREFIX)
                .append(azureCreateVMInputs.getAzureComputeCommonInputs().getAzureHost())
                .append(SUBSCRIPTION_PATH)
      Severity: Minor
      Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java and 1 other location - About 45 mins to fix
      cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java on lines 167..175

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              StringBuilder pathString = new StringBuilder()
                .append(azureCreateVMInputs.getAzureComputeCommonInputs().getAzureProtocol())
                .append(AZURE_PROTOCOL_PREFIX)
                .append(azureCreateVMInputs.getAzureComputeCommonInputs().getAzureHost())
                .append(SUBSCRIPTION_PATH)
      Severity: Minor
      Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java and 1 other location - About 45 mins to fix
      cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java on lines 142..150

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  availabilitySet.setId(SUBSCRIPTION_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getSubscriptionId() +
                    RESOURCE_GROUPS_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getResourceGroupName() + AZURE_CREATE_VM_AVAILABILITY_SET_PATH + inputs.getAvailabilitySetName());
      Severity: Minor
      Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java and 2 other locations - About 30 mins to fix
      cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java on lines 316..318
      cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java on lines 401..402

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  imageReference.setId(SUBSCRIPTION_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getSubscriptionId() +
                    RESOURCE_GROUPS_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getResourceGroupName() + AZURE_CREATE_VM_USING_CUSTOM_IMAGE_PATH
                    + inputs.getPrivateImageName());
      Severity: Minor
      Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java and 2 other locations - About 30 mins to fix
      cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java on lines 355..356
      cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java on lines 401..402

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              networkInterfaces1.setId(SUBSCRIPTION_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getSubscriptionId() +
                RESOURCE_GROUPS_PATH + inputs.getAzureComputeCommonInputs().getAzureCommonInputs().getResourceGroupName() + AZURE_CREATE_VM_NETWORK_INTERFACES_PATH + inputs.getNicName());
      Severity: Minor
      Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java and 2 other locations - About 30 mins to fix
      cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java on lines 316..318
      cs-azure/src/main/java/io/cloudslang/content/azure/services/AzureComputeImpl.java on lines 355..356

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status