Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-azure/src/main/java/io/cloudslang/content/azure/services/StreamingOutputJobImpl.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method createStreamingOutputJobRequestBody has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static String createStreamingOutputJobRequestBody(@NotNull final CreateStreamingOutputJobInputs inputs) throws Exception {
        CreateStreamingOutputJobRequestBody createStreamingOutputJobRequestBody = new CreateStreamingOutputJobRequestBody();
        CreateStreamingOutputJobRequestBody.Properties properties = new CreateStreamingOutputJobRequestBody.Properties();
        CreateStreamingOutputJobRequestBody.Datasource datasource = new CreateStreamingOutputJobRequestBody.Datasource();
        CreateStreamingOutputJobRequestBody.Serialization serialization = new CreateStreamingOutputJobRequestBody.Serialization();
Severity: Minor
Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/StreamingOutputJobImpl.java - About 1 hr to fix

    Method getCreateOutputStreamingJobUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private static String getCreateOutputStreamingJobUrl(String subscriptionId, String resourceGroupName, String jobName, String outputName, String apiVersion) throws Exception {
    Severity: Minor
    Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/StreamingOutputJobImpl.java - About 35 mins to fix

      Method createStreamingOutputJobPath has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private static String createStreamingOutputJobPath(String subscriptionId, String resourceGroupName, String jobName, String outputName, String apiVersion) {
      Severity: Minor
      Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/StreamingOutputJobImpl.java - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    public static Map<String, String> CreateOutputJob(@NotNull final CreateStreamingOutputJobInputs createStreamingOutputJobInputs)
            throws Exception {
        final HttpClientInputs httpClientInputs = new HttpClientInputs();
        httpClientInputs.setUrl(getCreateOutputStreamingJobUrl(createStreamingOutputJobInputs.getAzureCommonInputs().getSubscriptionId(), createStreamingOutputJobInputs.getAzureCommonInputs().getResourceGroupName(),
        Severity: Major
        Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/StreamingOutputJobImpl.java and 1 other location - About 2 hrs to fix
        cs-azure/src/main/java/io/cloudslang/content/azure/services/StreamingInputJobImpl.java on lines 55..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 128.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    private static String createStreamingOutputJobPath(String subscriptionId, String resourceGroupName, String jobName, String outputName, String apiVersion) {
        StringBuilder pathString = new StringBuilder()
                .append(DEFAULT_RESOURCE)
                .append(SUBSCRIPTION_PATH)
        Severity: Minor
        Found in cs-azure/src/main/java/io/cloudslang/content/azure/services/StreamingOutputJobImpl.java and 1 other location - About 50 mins to fix
        cs-azure/src/main/java/io/cloudslang/content/azure/services/StreamingInputJobImpl.java on lines 80..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status