CloudSlang/cs-actions

View on GitHub
cs-database/src/main/java/io/cloudslang/content/database/services/SQLQueryLobService.java

Summary

Maintainability
B
6 hrs
Test Coverage

Method executeSqlQueryLob has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    public static boolean executeSqlQueryLob(SQLInputs sqlInputs) throws Exception {
        if (StringUtils.isEmpty(sqlInputs.getSqlCommand())) {
            throw new Exception("command input is empty.");
        }
        boolean isLOB = false;

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method executeSqlQueryLob has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static boolean executeSqlQueryLob(SQLInputs sqlInputs) throws Exception {
        if (StringUtils.isEmpty(sqlInputs.getSqlCommand())) {
            throw new Exception("command input is empty.");
        }
        boolean isLOB = false;

    Avoid deeply nested control flow statements.
    Open

                                if (sqlInputs.getLRowsFiles().size() == nr) {
                                    sqlInputs.getLRowsFiles().add(nr, new ArrayList<String>());
                                    sqlInputs.getLRowsNames().add(nr, new ArrayList<String>());
                                }

      There are no issues that match your filters.

      Category
      Status