Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java

Summary

Maintainability
D
1 day
Test Coverage

Method setDataRows has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private static int setDataRows(final Sheet worksheet, final String rowData, final String rowDelimiter, final String columnDelimiter,
                                   final List<Integer> rowIndexList, final List<Integer> columnIndexList) {
        final String[] rows = rowData.split(rowDelimiter);
        String[] columns;
Severity: Minor
Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addExcelData has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @NotNull
    public static Map<String, String> addExcelData(AddCellInputs addExcelDataInputs) {
        boolean hasHeaderData = false;
        try {
            final String excelFileName = addExcelDataInputs.getCommonInputs().getExcelFileName();
Severity: Minor
Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 2 hrs to fix

    Method setDataRows has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public static int setDataRows(final Sheet worksheet,
                                  final String rowData,
                                  final String rowDelimiter,
                                  final String columnDelimiter,
                                  final int startRowIndex,
    Severity: Minor
    Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method shiftRows has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public static void shiftRows(final Sheet worksheet, final List<Integer> rowIndexList) {
        int insertPoint;
        int nRows;
        int i = 0;
        while (i < rowIndexList.size()) {
    Severity: Minor
    Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setDataRows has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static int setDataRows(final Sheet worksheet, final String rowData, final String rowDelimiter, final String columnDelimiter,
                                   final List<Integer> rowIndexList, final List<Integer> columnIndexList) {
        final String[] rows = rowData.split(rowDelimiter);
        String[] columns;
    Severity: Minor
    Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 1 hr to fix

      Method addExcelData has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          @NotNull
    public static Map<String, String> addExcelData(AddCellInputs addExcelDataInputs) {
        boolean hasHeaderData = false;
        try {
            final String excelFileName = addExcelDataInputs.getCommonInputs().getExcelFileName();
      Severity: Minor
      Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setDataRows has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static int setDataRows(final Sheet worksheet,
                                  final String rowData,
                                  final String rowDelimiter,
                                  final String columnDelimiter,
                                  final int startRowIndex,
      Severity: Minor
      Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 1 hr to fix

        Method setDataRows has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static int setDataRows(final Sheet worksheet,
                                  final String rowData,
                                  final String rowDelimiter,
                                  final String columnDelimiter,
                                  final int startRowIndex,
        Severity: Minor
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 45 mins to fix

          Method setDataRows has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private static int setDataRows(final Sheet worksheet, final String rowData, final String rowDelimiter, final String columnDelimiter,
                                   final List<Integer> rowIndexList, final List<Integer> columnIndexList) {
          Severity: Minor
          Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 45 mins to fix

            Avoid too many return statements within this method.
            Open

                        return getSuccessResultsMap(String.valueOf(rowsAdded));
            Severity: Major
            Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return getFailureResultsMap(e.getMessage());
              Severity: Major
              Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            try {
                double valueNumeric = Double.parseDouble(tmp[i].trim());
                cell.setCellValue(valueNumeric);
            }
            //for non-numeric value
                Severity: Minor
                Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java and 1 other location - About 40 mins to fix
                cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java on lines 231..238

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                try {
                    double value_num = Double.parseDouble(tmpCol[j].trim());
                    cell.setCellValue(value_num);
                }
                //for non-numeric value
                Severity: Minor
                Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java and 1 other location - About 40 mins to fix
                cs-excel/src/main/java/io/cloudslang/content/excel/services/AddCellService.java on lines 264..271

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status