Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-excel/src/main/java/io/cloudslang/content/excel/services/CreateExcelFileService.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method getNewExcelDocument has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private static Workbook getNewExcelDocument(final String excelFileName) throws Exception {
        final String format = getFileFormat(excelFileName);

        if (StringUtils.isBlank(format)) {
            throw new Exception(BAD_CREATE_EXCEL_FILE_MSG);
Severity: Minor
Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/CreateExcelFileService.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method newExcelDocument has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @NotNull
    public static Map<String, String> newExcelDocument(@NotNull final CreateExcelFileInputs newExcelDocumentInputs) {
        final String excelFileName = newExcelDocumentInputs.getExcelFileName();
        final Workbook excelDoc;
        try {
Severity: Minor
Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/CreateExcelFileService.java - About 1 hr to fix

    Method getNewExcelDocument has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static Workbook getNewExcelDocument(final String excelFileName) throws Exception {
        final String format = getFileFormat(excelFileName);

        if (StringUtils.isBlank(format)) {
            throw new Exception(BAD_CREATE_EXCEL_FILE_MSG);
    Severity: Minor
    Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/CreateExcelFileService.java - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return OutputUtilities.getSuccessResultsMap(excelFileName + " created successfully");
      Severity: Major
      Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/CreateExcelFileService.java - About 30 mins to fix

        Method newExcelDocument has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            @NotNull
    public static Map<String, String> newExcelDocument(@NotNull final CreateExcelFileInputs newExcelDocumentInputs) {
        final String excelFileName = newExcelDocumentInputs.getExcelFileName();
        final Workbook excelDoc;
        try {
        Severity: Minor
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/services/CreateExcelFileService.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status