Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java

Summary

Maintainability
C
1 day
Test Coverage

Method addVerifyIndex has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    @NotNull
    private static List<String> addVerifyIndex(@NotNull List<String> exceptions, @NotNull final String input, @NotNull final String inputName) {
        if (input.isEmpty())
            return exceptions;
Severity: Minor
Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method verifyGetCellInputs has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public static List<String> verifyGetCellInputs(@NotNull final String excelFileName,
                                                   @NotNull final String hasHeader,
                                                   @NotNull final String firstRowIndex,
                                                   @NotNull final String rowIndex,
                                                   @NotNull final String columnIndex,
Severity: Minor
Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java - About 45 mins to fix

    Method verifyAddExcelData has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static List<String> verifyAddExcelData(@NotNull final String excelFileName,
                                                  @NotNull final String rowData,
                                                  @NotNull final String rowIndex,
                                                  @NotNull final String columnIndex,
                                                  @NotNull final String overwriteData) {
    Severity: Minor
    Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java - About 35 mins to fix

      Method verifyGetCellRowIndexbyCondition has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static List<String> verifyGetCellRowIndexbyCondition(@NotNull final String excelFileName,
                                                                @NotNull final String hasHeader,
                                                                @NotNull final String firstRowIndex,
                                                                @NotNull final String columnIndextoQuery,
                                                                @NotNull final String operator) {
      Severity: Minor
      Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    private static List<String> addVerifyPositiveNumber(@NotNull List<String> exceptions, @NotNull final String input, @NotNull final String inputName) {
        if (isEmpty(input)) {
            exceptions.add(String.format(EXCEPTION_EMPTY, inputName));
        } else if (!NumberUtilities.isValidInt(input)) {
        Severity: Major
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java and 1 other location - About 1 hr to fix
        cs-rft/src/main/java/io/cloudslang/content/rft/utils/InputsValidation.java on lines 291..301

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            @NotNull
    public static List<String> verifyAddExcelData(@NotNull final String excelFileName,
                                                  @NotNull final String rowData,
                                                  @NotNull final String rowIndex,
                                                  @NotNull final String columnIndex,
        Severity: Major
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java and 4 other locations - About 1 hr to fix
        cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java on lines 117..132
        cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/InputsValidation.java on lines 46..63
        cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/InputsValidation.java on lines 89..106
        cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/utils/InputsValidation.java on lines 61..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            @NotNull
    public static List<String> verifyGetCellRowIndexbyCondition(@NotNull final String excelFileName,
                                                                @NotNull final String hasHeader,
                                                                @NotNull final String firstRowIndex,
                                                                @NotNull final String columnIndextoQuery,
        Severity: Major
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java and 4 other locations - About 1 hr to fix
        cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java on lines 55..70
        cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/InputsValidation.java on lines 46..63
        cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/InputsValidation.java on lines 89..106
        cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/utils/InputsValidation.java on lines 61..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    private static List<String> addVerifyFile(@NotNull List<String> exceptions, @NotNull final String filePath, @NotNull final String inputName) {
        if (isEmpty(filePath)) {
            exceptions.add(EXCEPTION_EMPTY_FILE_PATH);
        } else if (!isEmpty(filePath) && !isValidFile(filePath)) {
        Severity: Minor
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java and 1 other location - About 50 mins to fix
        cs-tesseract/src/main/java/io/cloudslang/content/tesseract/utils/InputsValidation.java on lines 95..104

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            @NotNull
    public static List<String> verifyModifyCellInputs(@NotNull final String excelFileName,
                                                      @NotNull final String rowIndex,
                                                      @NotNull final String columnIndex,
                                                      @NotNull final String newValue) {
        Severity: Major
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java and 3 other locations - About 50 mins to fix
        cs-azure/src/main/java/io/cloudslang/content/azure/utils/InputsValidation.java on lines 60..68
        cs-azure/src/main/java/io/cloudslang/content/azure/utils/InputsValidation.java on lines 151..159
        cs-tesseract/src/main/java/io/cloudslang/content/tesseract/utils/InputsValidation.java on lines 81..93

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 12 locations. Consider refactoring.
        Open

            @NotNull
    private static List<String> addVerifyBoolean(@NotNull List<String> exceptions, @NotNull final String input, @NotNull final String inputName) {
        if (isEmpty(input)) {
            exceptions.add(String.format(EXCEPTION_EMPTY, inputName));
        } else if (!isValid(input)) {
        Severity: Major
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java and 11 other locations - About 50 mins to fix
        cs-azure/src/main/java/io/cloudslang/content/azure/utils/InputsValidation.java on lines 116..125
        cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/InputsValidation.java on lines 251..260
        cs-httpclient-commons/src/main/java/io/cloudslang/content/httpclient/utils/InputsValidator.java on lines 132..140
        cs-microfocus-sitescope/src/main/java/io/cloudslang/content/sitescope/utils/InputsValidation.java on lines 138..146
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/InputsValidation.java on lines 64..73
        cs-office-365/src/main/java/io/cloudslang/content/office365/utils/InputsValidation.java on lines 332..340
        cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/utils/InputsValidation.java on lines 63..72
        cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/utils/InputsValidation.java on lines 102..110
        cs-tesseract/src/main/java/io/cloudslang/content/tesseract/utils/InputsValidation.java on lines 114..122
        cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/InputsValidation.java on lines 113..121
        cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/InputsValidation.java on lines 123..131

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (size > 0) {
                final String indexValue = compositeIndex.get(0).trim();
                if (!isNumeric(indexValue)) {
                    exceptions.add(String.format(EXCEPTION_INVALID_INDEX_NOT_A_NUMBER, indexValue, inputName));
                }
        Severity: Minor
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java and 1 other location - About 40 mins to fix
        cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java on lines 234..239

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (size == 2) {
                final String indexValueRight = compositeIndex.get(1).trim();
                if (!isNumeric(indexValueRight)) {
                    exceptions.add(String.format(EXCEPTION_INVALID_INDEX_NOT_A_NUMBER, indexValueRight, inputName));
                }
        Severity: Minor
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java and 1 other location - About 40 mins to fix
        cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java on lines 227..232

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    public static List<String> verifyDeleteCell(@NotNull final String excelFileName,
                                                @NotNull final String rowIndex,
                                                @NotNull final String columnIndex) {
        final List<String> exceptionMessages = new ArrayList<>();
        Severity: Minor
        Found in cs-excel/src/main/java/io/cloudslang/content/excel/utils/InputsValidation.java and 1 other location - About 40 mins to fix
        cs-azure/src/main/java/io/cloudslang/content/azure/utils/InputsValidation.java on lines 142..149

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status