Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala

Summary

Maintainability
C
1 day
Test Coverage

Method create has 23 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def create(httpTransport: HttpTransport, jsonFactory: JsonFactory, credential: Credential, projectId: String,
             databaseInstanceId: String, password: String, region: String, zone: String, databaseVersion: String,
             tier: String, dataDiskType: String, dataDiskSizeInGB: Long,
             storageAutoResize: Boolean,privateNetwork: String, isIPV4Enabled: Boolean, availabilityType: String, maintenanceWindowDay: Int, maintenanceWindowHour: Int
             , activationPolicy: String, labels: java.util.Map[String, String], async: Boolean, timeout: Long,
Severity: Major
Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala - About 2 hrs to fix

    Method update has 21 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def update(httpTransport: HttpTransport, jsonFactory: JsonFactory, credential: Credential, projectId: String,
             databaseInstanceId: String, zone: String, settingsVersion: Long, databaseVersion: String, tier: String,
             dataDiskSizeInGB: Long, storageAutoResize: Boolean, privateNetwork: String, isIPV4Enabled: Boolean, availabilityType: String,
             maintenanceWindowDay: Int, maintenanceWindowHour: Int, activationPolicy: String, labels: java.util.Map[String, String],
             async: Boolean, timeout: Long, pollingInterval: Long): Operation = {
    Severity: Major
    Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala - About 2 hrs to fix

      Function update has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                   async: Boolean, timeout: Long, pollingInterval: Long): Operation = {

    val databaseInstance = new DatabaseInstance()
    val settings = new Settings()
    val maintenanceWindow = new MaintenanceWindow().setDay(maintenanceWindowDay).setHour(maintenanceWindowHour)
      Severity: Minor
      Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala - About 1 hr to fix

        Method instanceOperation has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def instanceOperation(httpTransport: HttpTransport, jsonFactory: JsonFactory, credential: Credential,
                        projectId: String, databaseInstanceId: String, instanceOperation: String, async: Boolean, timeout: Long,
                        pollingInterval: Long): Operation = {
        Severity: Major
        Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala - About 1 hr to fix

          Method delete has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def delete(httpTransport: HttpTransport, jsonFactory: JsonFactory, credential: Credential,
             projectId: String, databaseInstanceId: String, async: Boolean, timeout: Long,
             pollingInterval: Long): Operation = {
          Severity: Major
          Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala - About 1 hr to fix

            Method list has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def list(httpTransport: HttpTransport, jsonFactory: JsonFactory, credential: Credential, project: String,
           filterOpt: Option[String]): List[DatabaseInstance] = {
            Severity: Minor
            Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala - About 35 mins to fix

              Method get has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def get(httpTransport: HttpTransport, jsonFactory: JsonFactory, credential: Credential,
          projectId: String, databaseInstanceId: String):
              Severity: Minor
              Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala - About 35 mins to fix

                Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def update(httpTransport: HttpTransport, jsonFactory: JsonFactory, credential: Credential, projectId: String,
             databaseInstanceId: String, zone: String, settingsVersion: Long, databaseVersion: String, tier: String,
             dataDiskSizeInGB: Long, storageAutoResize: Boolean, privateNetwork: String, isIPV4Enabled: Boolean, availabilityType: String,
             maintenanceWindowDay: Int, maintenanceWindowHour: Int, activationPolicy: String, labels: java.util.Map[String, String],
             async: Boolean, timeout: Long, pollingInterval: Long): Operation = {
                Severity: Minor
                Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        setSettings(new Settings().setTier(tier).setUserLabels(labels).setDataDiskType(dataDiskType)
          .setDataDiskSizeGb(dataDiskSizeInGB).setStorageAutoResize(storageAutoResize).
          setAvailabilityType(availabilityType)
          .setMaintenanceWindow(new MaintenanceWindow().setDay(maintenanceWindowDay).setHour(maintenanceWindowHour))
                Severity: Minor
                Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala and 2 other locations - About 30 mins to fix
                cs-google/src/main/scala/io/cloudslang/content/google/services/compute/compute_engine/instances/InstanceController.scala on lines 37..44
                cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala on lines 72..82

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                      .insert(projectId, new DatabaseInstance().setProject(projectId).setName(databaseInstanceId).setRegion(region).
        setDatabaseVersion(databaseVersion).setRootPassword(password).setGceZone(zone).
        setSettings(new Settings().setTier(tier).setUserLabels(labels).setDataDiskType(dataDiskType)
          .setDataDiskSizeGb(dataDiskSizeInGB).setStorageAutoResize(storageAutoResize).
          setAvailabilityType(availabilityType)
                Severity: Minor
                Found in cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala and 2 other locations - About 30 mins to fix
                cs-google/src/main/scala/io/cloudslang/content/google/services/compute/compute_engine/instances/InstanceController.scala on lines 37..44
                cs-google/src/main/scala/io/cloudslang/content/google/services/databases/sql/instances/SQLDatabaseInstanceService.scala on lines 74..77

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status