Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java

Summary

Maintainability
D
2 days
Test Coverage

File HttpClientService.java has 387 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright 2022-2024 Open Text
 * This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
Severity: Minor
Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java - About 5 hrs to fix

    Method buildHttpComponents has 120 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public HttpComponents buildHttpComponents(HttpClientInputs httpClientInputs) {
        buildDefaultServices();

        URI uri = uriBuilder.setUrl(httpClientInputs.getUrl())
                .setQueryParams(httpClientInputs.getQueryParams())
    Severity: Major
    Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java - About 4 hrs to fix

      Method buildDefaultServices has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          private void buildDefaultServices() {
        if (uriBuilder == null) {
            uriBuilder = new URIBuilder();
        }
        if (contentTypeBuilder == null) {
      Severity: Minor
      Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method buildDefaultServices has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void buildDefaultServices() {
        if (uriBuilder == null) {
            uriBuilder = new URIBuilder();
        }
        if (contentTypeBuilder == null) {
      Severity: Major
      Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java - About 2 hrs to fix

        Method execute has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public Map<String, String> execute(HttpClientInputs httpClientInputs) throws Exception {
        initSessionsObjects(httpClientInputs);
        HttpComponents httpComponents = buildHttpComponents(httpClientInputs);
        final Map<String, String>[] result = new Map[]{new HashMap<>()};
        if(StringUtils.isEmpty(httpClientInputs.getExecutionTimeout())){
        Severity: Minor
        Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java - About 1 hr to fix

          Method parseResponse has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public Map<String, String> parseResponse(CloseableHttpResponse httpResponse,
                                             String responseCharacterSet,
                                             String destinationFile,
                                             URI uri,
                                             HttpClientContext httpClientContext,
          Severity: Minor
          Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java - About 1 hr to fix

            Method parseResponse has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public Map<String, String> parseResponse(CloseableHttpResponse httpResponse,
                                             String responseCharacterSet,
                                             String destinationFile,
                                             URI uri,
                                             HttpClientContext httpClientContext,
            Severity: Major
            Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java - About 50 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (httpClientInputs.getExecutionTimeout().equals("0")) {
                    CloseableHttpResponse httpResponse = execute(httpComponents.getCloseableHttpClient(),
                            httpComponents.getHttpRequestBase(),
                            httpComponents.getHttpClientContext());
              Severity: Major
              Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java and 1 other location - About 1 hr to fix
              cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java on lines 128..146

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              @Override
                public void run() {
                    CloseableHttpResponse httpResponse = execute(httpComponents.getCloseableHttpClient(),
                            httpComponents.getHttpRequestBase(),
                            httpComponents.getHttpClientContext());
              Severity: Major
              Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java and 1 other location - About 1 hr to fix
              cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java on lines 109..126

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (cookieStore != null) {
            try {
                cookieStoreSessionObject.setValue(
                        CookieStoreBuilder.serialize(cookieStore));
            } catch (IOException e) {
              Severity: Minor
              Found in cs-http-client/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java and 1 other location - About 30 mins to fix
              cs-httpclient-commons/src/main/java/io/cloudslang/content/httpclient/services/HttpClientService.java on lines 131..138

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status