Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-httpclient-commons/src/main/java/io/cloudslang/content/httpclient/utils/Descriptions.java

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public static final String QUERY_PARAMS_ARE_FORM_ENCODED_DESC = "Specifies whether to encode the query_params in " +
                "the form request format or not. This format is the default format used by the apache http client library. " +
                "If query_params_are_URL_encoded=true then all characters will be encoded based on the " +
                "query_params_are_URL_encoded input. If query_params_are_URL_encoded=false all reserved characters are not " +
                "encoded no matter of query_params_are_URL_encoded input. The only exceptions are for ' '(space) character " +
Severity: Minor
Found in cs-httpclient-commons/src/main/java/io/cloudslang/content/httpclient/utils/Descriptions.java and 1 other location - About 45 mins to fix
cs-xml/src/test/java/io/cloudslang/content/xml/actions/ConvertXmlToJsonTest.java on lines 88..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        public static final String ALLOWED_CIPHERS_DESC = "A list of ciphers to use. The value of this input will be ignored " +
                "if 'tlsVersion' does\n" +
                "not contain 'TLSv1.2'. This capability is provided “as is”, please see product documentation for further security considerations." +
                "In order to connect successfully to the target host, it should accept at least one of the following ciphers. If this is not the case, it is\n" +
                "the user's responsibility to configure the host accordingly or to update the list of allowed ciphers. \n" +
Severity: Major
Found in cs-httpclient-commons/src/main/java/io/cloudslang/content/httpclient/utils/Descriptions.java and 7 other locations - About 30 mins to fix
cs-active-directory/src/main/java/io/cloudslang/content/active_directory/constants/Descriptions.java on lines 55..64
cs-cyberark/src/main/java/io/cloudslang/content/cyberark/utils/Constants.java on lines 58..67
cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/Descriptions.java on lines 188..197
cs-openshift/src/main/java/io/cloudslang/content/redhat/utils/Descriptions.java on lines 25..34
cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/utils/Descriptions.java on lines 62..71
cs-utilities/src/test/java/io/cloudslang/content/utilities/services/localping/WindowsPingCommandTest.java on lines 41..50
cs-utilities/src/test/java/io/cloudslang/content/utilities/util/CommandOutputParserTest.java on lines 37..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status