CloudSlang/cs-actions

View on GitHub
cs-json/src/main/java/io/cloudslang/content/json/actions/AddJsonPropertyToObject.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method execute has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Action(name = "Add JSON Property to Object",
            outputs = {
                    @Output(OutputNames.RETURN_RESULT),
                    @Output(OutputNames.RETURN_CODE),
                    @Output(OutputNames.EXCEPTION)

    Method execute has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        @Action(name = "Add JSON Property to Object",
                outputs = {
                        @Output(OutputNames.RETURN_RESULT),
                        @Output(OutputNames.RETURN_CODE),
                        @Output(OutputNames.EXCEPTION)

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return populateResult(returnResult, exceptionValue, exception);

      Avoid too many return statements within this method.
      Open

              return populateResult(returnResult, jsonNodes.toString(), null);

        Avoid too many return statements within this method.
        Open

                    return populateResult(returnResult, new Exception(CANNOT_ADD_VALUE));

          There are no issues that match your filters.

          Category
          Status