Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-json/src/main/java/io/cloudslang/content/json/utils/JsonUtils.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method validateEditJsonInputs has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static void validateEditJsonInputs(String jsonObject, String jsonPath, String action, String name, String value) throws Exception {
        if (StringUtilities.isBlank(jsonObject)) {
            throw new Exception(EMPTY_JSONOBJECT);
        }
        if (StringUtilities.isBlank(jsonPath)) {
Severity: Minor
Found in cs-json/src/main/java/io/cloudslang/content/json/utils/JsonUtils.java - About 1 hr to fix

    Method validateEditJsonInputs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public static void validateEditJsonInputs(String jsonObject, String jsonPath, String action, String name, String value) throws Exception {
        if (StringUtilities.isBlank(jsonObject)) {
            throw new Exception(EMPTY_JSONOBJECT);
        }
        if (StringUtilities.isBlank(jsonPath)) {
    Severity: Minor
    Found in cs-json/src/main/java/io/cloudslang/content/json/utils/JsonUtils.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validateEditJsonInputs has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static void validateEditJsonInputs(String jsonObject, String jsonPath, String action, String name, String value) throws Exception {
    Severity: Minor
    Found in cs-json/src/main/java/io/cloudslang/content/json/utils/JsonUtils.java - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status