Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-json/src/test/java/io/cloudslang/content/json/actions/GetValueFromObjectTest.java

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void testExecuteSimpleCaseEmptyValues() {
        String jsonObject = " { \"city\" : \"\", \n" +
                "     \"state\" : \"\" }";
        String key = "city";
Severity: Major
Found in cs-json/src/test/java/io/cloudslang/content/json/actions/GetValueFromObjectTest.java and 1 other location - About 1 hr to fix
cs-json/src/test/java/io/cloudslang/content/json/actions/GetValueFromObjectTest.java on lines 37..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void testExecuteSimpleCase() {
        String jsonObject = " { \"city\" : \"Palo Alto\", \n" +
                "     \"state\" : \"CA\" }";
        String key = "city";
Severity: Major
Found in cs-json/src/test/java/io/cloudslang/content/json/actions/GetValueFromObjectTest.java and 1 other location - About 1 hr to fix
cs-json/src/test/java/io/cloudslang/content/json/actions/GetValueFromObjectTest.java on lines 50..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    @Test
    public void testExecuteNameBad() {
        String jsonObject = "{}";
        String key = "test{\"";
        final Map<String, String> result = getValueFromObject.execute(jsonObject, key);
Severity: Major
Found in cs-json/src/test/java/io/cloudslang/content/json/actions/GetValueFromObjectTest.java and 4 other locations - About 35 mins to fix
cs-json/src/test/java/io/cloudslang/content/json/actions/GetValueFromObjectTest.java on lines 204..210
cs-json/src/test/java/io/cloudslang/content/json/actions/MergeArraysTest.java on lines 37..43
cs-json/src/test/java/io/cloudslang/content/json/actions/MergeArraysTest.java on lines 45..51
cs-json/src/test/java/io/cloudslang/content/json/actions/MergeArraysTest.java on lines 53..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    @Test
    public void testExecuteJsonObjectSpecialCharsInKey() {
        String jsonObject = "{\"one\":{\"a\":\"a\",\"B\":\"B\"}, \"two\":\"two\", \"three;/?:@&=+,$\":[1,2,3.4]}";
        String key = "tes;/?:@&=+,$t";
        final Map<String, String> result = getValueFromObject.execute(jsonObject, key);
Severity: Major
Found in cs-json/src/test/java/io/cloudslang/content/json/actions/GetValueFromObjectTest.java and 4 other locations - About 35 mins to fix
cs-json/src/test/java/io/cloudslang/content/json/actions/GetValueFromObjectTest.java on lines 196..202
cs-json/src/test/java/io/cloudslang/content/json/actions/MergeArraysTest.java on lines 37..43
cs-json/src/test/java/io/cloudslang/content/json/actions/MergeArraysTest.java on lines 45..51
cs-json/src/test/java/io/cloudslang/content/json/actions/MergeArraysTest.java on lines 53..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status