Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-mail/src/main/java/io/cloudslang/content/mail/utils/InputBuilderUtils.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method buildPortAndProtocol has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public static Map<String, Object> buildPortAndProtocol(String protocol, String port) throws Exception {
        Map<String, Object> result = new HashMap<>();
        final String protocolKey = "protocol";
        final String portKey = "port";
Severity: Minor
Found in cs-mail/src/main/java/io/cloudslang/content/mail/utils/InputBuilderUtils.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buildPortAndProtocol has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static Map<String, Object> buildPortAndProtocol(String protocol, String port) throws Exception {
        Map<String, Object> result = new HashMap<>();
        final String protocolKey = "protocol";
        final String portKey = "port";
Severity: Minor
Found in cs-mail/src/main/java/io/cloudslang/content/mail/utils/InputBuilderUtils.java - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            } else if ((protocol != null && !protocol.isEmpty()) && (!protocol.equalsIgnoreCase(Constants.IMAP)) &&
                (!protocol.equalsIgnoreCase(Constants.POP3)) && (!protocol.equalsIgnoreCase(Constants.IMAP4)) &&
                isEmpty(port)) {
            throw new Exception(ExceptionMsgs.SPECIFY_PORT_FOR_PROTOCOL);
        } else if (isEmpty(protocol) && !isEmpty(port) &&
    Severity: Major
    Found in cs-mail/src/main/java/io/cloudslang/content/mail/utils/InputBuilderUtils.java - About 40 mins to fix

      Method buildPort has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static Short buildPort(String port, boolean mandatory) throws Exception {
        if (StringUtils.isEmpty(port)) {
            if (!mandatory) {
                return null;
            } else {
      Severity: Minor
      Found in cs-mail/src/main/java/io/cloudslang/content/mail/utils/InputBuilderUtils.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status