CloudSlang/cs-actions

View on GitHub
cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java

Summary

Maintainability
D
1 day
Test Coverage

File SendMailServiceTest.java has 466 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright 2021-2024 Open Text
 * This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *

    Method testExecuteGoesToSuccessScenarioWithHTMLAndBase64Images has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Test
        public void testExecuteGoesToSuccessScenarioWithHTMLAndBase64Images() throws Exception {
            prepareTransportClassForStaticMock();
            Mockito.doNothing().when(mimeBodyPartMock).setContent(HTML_BODY_BASE64_IMAGES_AFTER_PROCESSING,
                    TEXT_HTML + CHARSET_CST + DEFAULT_CHARACTERSET);

      Method testExecuteGoesToSuccessScenario3 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Test
          public void testExecuteGoesToSuccessScenario3() throws Exception {
              prepareTransportClassForStaticMock();
              Mockito.doNothing().when(mimeBodyPartMock).setContent(BODY, TEXT_PLAIN + CHARSET_CST + DEFAULT_CHARACTERSET);
              PowerMockito.whenNew(FileDataSource.class).withArguments(anyString()).thenReturn(fileDataSourceMock);

        Method testExecuteGoesToSuccessScenario1 has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Test
            public void testExecuteGoesToSuccessScenario1() throws Exception {
                Mockito.doReturn(transportMock).when(sessionMock).getTransport(SMTP_PROTOCOL);
                Mockito.doNothing().when(transportMock).connect(SMTP_HOSTANME, INT_PORT, USER, PASSWORD);
                Mockito.doNothing().when(transportMock).sendMessage(Matchers.<SMTPMessage>any(), Matchers.<Address[]>any());

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  inputBuilder.hostname(SMTP_HOSTANME)
                          .port(PORT)
                          .from(FROM)
                          .to(TO)
                          .cc(CC)
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 393..403
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 434..444

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  inputBuilder.hostname(SMTP_HOSTANME)
                          .port(PORT)
                          .from(FROM)
                          .to(TO)
                          .cc(CC)
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 232..242
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 434..444

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  inputBuilder.hostname(SMTP_HOSTANME)
                          .port(PORT)
                          .from(FROM)
                          .to(TO)
                          .cc(CC)
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 232..242
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 393..403

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  inputBuilder.hostname(SMTP_HOSTANME)
                          .port(PORT)
                          .from(FROM)
                          .to(TO + DEFAULT_DELIMITER + TO2)
                          .cc(CC)
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 461..468

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  inputBuilder.hostname(SMTP_HOSTANME)
                          .port(PORT)
                          .from(FROM)
                          .to(TO + DEFAULT_DELIMITER + TO2)
                          .cc(CC)
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 574..581

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  inputBuilder.hostname(SMTP_HOSTANME)
                          .port(PORT)
                          .from(FROM)
                          .to(TO)
                          .cc(CC)
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 342..350

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  inputBuilder.hostname(SMTP_HOSTANME)
                          .port(PORT)
                          .from(FROM)
                          .to(TO)
                          .cc(CC)
          cs-mail/src/test/java/io/cloudslang/content/mail/services/SendMailServiceTest.java on lines 510..518

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status