Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java

Summary

Maintainability
D
2 days
Test Coverage

File VMImpl.java has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open



package io.cloudslang.content.nutanix.prism.services;

import com.fasterxml.jackson.core.JsonProcessingException;
Severity: Minor
Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java - About 4 hrs to fix

    Method createVMBody has 90 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @NotNull
    public static String createVMBody(NutanixCreateVMInputs nutanixCreateVMInputs, String delimiter) {
        String requestBody = EMPTY;
        final List<String> hostUUIDsList = new ArrayList<>();
        ObjectMapper createVMMapper = new ObjectMapper();
    Severity: Major
    Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java - About 3 hrs to fix

      Method updateVMBody has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @NotNull
    public static String updateVMBody(NutanixUpdateVMInputs nutanixUpdateVMInputs, String delimiter)
            throws JsonProcessingException {
        String requestBody = EMPTY;
        final List<String> hostUUIDsList = new ArrayList<>();
      Severity: Minor
      Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java - About 1 hr to fix

        Method createVMBody has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            @NotNull
    public static String createVMBody(NutanixCreateVMInputs nutanixCreateVMInputs, String delimiter) {
        String requestBody = EMPTY;
        final List<String> hostUUIDsList = new ArrayList<>();
        ObjectMapper createVMMapper = new ObjectMapper();
        Severity: Minor
        Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method updateVMBody has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            @NotNull
    public static String updateVMBody(NutanixUpdateVMInputs nutanixUpdateVMInputs, String delimiter)
            throws JsonProcessingException {
        String requestBody = EMPTY;
        final List<String> hostUUIDsList = new ArrayList<>();
        Severity: Minor
        Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    public static Map<String, String> setVMPowerState(@NotNull final NutanixSetVMPowerStateInputs nutanixSetVMPowerStateInputs)
            throws Exception {
        final HttpClientInputs httpClientInputs = new HttpClientInputs();
        httpClientInputs.setUrl(setVMPowerStateURL(nutanixSetVMPowerStateInputs));
        Severity: Major
        Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java and 1 other location - About 1 hr to fix
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/NicImpl.java on lines 31..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            @NotNull
    public static String getVMDetailsURL(NutanixGetVMDetailsInputs nutanixGetVMDetailsInputs) throws Exception {

        final URIBuilder uriBuilder = getUriBuilder(nutanixGetVMDetailsInputs.getCommonInputs());
        StringBuilder pathString = new StringBuilder()
        Severity: Major
        Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java and 3 other locations - About 1 hr to fix
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/TaskImpl.java on lines 36..48
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java on lines 179..191
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java on lines 193..204

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            @NotNull
    public static String updateVMURL(NutanixUpdateVMInputs nutanixUpdateVMInputs) throws Exception {

        final URIBuilder uriBuilder = getUriBuilder(nutanixUpdateVMInputs.getCommonInputs());
        StringBuilder pathString = new StringBuilder()
        Severity: Major
        Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java and 3 other locations - About 1 hr to fix
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/TaskImpl.java on lines 36..48
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java on lines 153..165
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java on lines 193..204

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public static String deleteVMURL(NutanixDeleteVMInputs nutanixDeleteVMInputs) throws Exception {

        final URIBuilder uriBuilder = getUriBuilder(nutanixDeleteVMInputs.getCommonInputs());
        StringBuilder pathString = new StringBuilder()
                .append(API)
        Severity: Major
        Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java and 3 other locations - About 1 hr to fix
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/TaskImpl.java on lines 36..48
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java on lines 153..165
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java on lines 179..191

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    public static String createVMURL(NutanixCreateVMInputs nutanixCreateVMInputs) throws Exception {

        final URIBuilder uriBuilder = getUriBuilder(nutanixCreateVMInputs.getCommonInputs());
        StringBuilder pathString = new StringBuilder()
        Severity: Minor
        Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java and 1 other location - About 50 mins to fix
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java on lines 141..151

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    public static String listVMsURL(NutanixListVMsInputs nutanixListVMsInputs) throws Exception {

        final URIBuilder uriBuilder = getUriBuilder(nutanixListVMsInputs.getCommonInputs());
        StringBuilder pathString = new StringBuilder()
        Severity: Minor
        Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java and 1 other location - About 50 mins to fix
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/services/VMImpl.java on lines 167..177

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status