Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java

Summary

Maintainability
C
1 day
Test Coverage

Method getQueryParams has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @NotNull
    public static String getQueryParams(String filter, String offset, String length,
                                        String sortOrder, String sortAttribute, String includeVMDiskConfigInfo, final String includeVMNicConfigInfo) {
        final StringBuilder queryParams = new StringBuilder()
                .append(Constants.Common.QUERY)
Severity: Minor
Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java - About 1 hr to fix

    Method setSecurityInputs has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static void setSecurityInputs(@NotNull final HttpClientInputs httpClientInputs,
                                         @NotNull final String trustAllRoots,
                                         @NotNull final String x509HostnameVerifier,
                                         @NotNull final String trustKeystore,
                                         @NotNull final String trustPassword,
    Severity: Major
    Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java - About 50 mins to fix

      Method setConnectionParameters has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static void setConnectionParameters(HttpClientInputs httpClientInputs,
                                               @NotNull final String connectTimeout,
                                               @NotNull final String socketTimeout,
                                               @NotNull final String keepAlive,
                                               @NotNull final String connectionsMaxPerRoot,
      Severity: Major
      Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java - About 50 mins to fix

        Method getQueryParams has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static String getQueryParams(String filter, String offset, String length,
                                        String sortOrder, String sortAttribute, String includeVMDiskConfigInfo, final String includeVMNicConfigInfo) {
        Severity: Major
        Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java - About 50 mins to fix

          Method getTaskFailureResults has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static Map<String, String> getTaskFailureResults(@NotNull String inputName, @NotNull Integer statusCode,
                                                            @NotNull String taskStatus, @NotNull String returnMessage,
                                                            @NotNull String throwable) {
          Severity: Minor
          Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java - About 35 mins to fix

            Method setProxy has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static void setProxy(@NotNull final HttpClientInputs httpClientInputs,
                                @NotNull final String proxyHost,
                                @NotNull final String proxyPort,
                                @NotNull final String proxyUsername,
                                @NotNull final String proxyPassword) {
            Severity: Minor
            Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java - About 35 mins to fix

              Method getTaskFailureResults has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  @NotNull
    public static Map<String, String> getTaskFailureResults(@NotNull String inputName, @NotNull Integer statusCode,
                                                            @NotNull String taskStatus, @NotNull String returnMessage,
                                                            @NotNull String throwable) {
        Map<String, String> results = new HashMap();
              Severity: Minor
              Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 5 locations. Consider refactoring.
              Open

                  @NotNull
    public static Map<String, String> getOperationResults(@NotNull final Map<String, String> result,
                                                          @NotNull final String successMessage,
                                                          final String failureMessage,
                                                          final String document) {
              Severity: Major
              Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java and 4 other locations - About 1 hr to fix
              cs-azure/src/main/java/io/cloudslang/content/azure/utils/HttpUtils.java on lines 104..120
              cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/HttpUtils.java on lines 68..84
              cs-office-365/src/main/java/io/cloudslang/content/office365/utils/HttpUtils.java on lines 281..297
              cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/utils/HttpUtils.java on lines 78..94

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      } else if (statusCode.equals(500)) {
            final String errorDetail = JsonPath.read(returnMessage, ERROR_MESSAGE_PATH);
            results.put(RETURN_RESULT, "  error Message : " + errorDetail);
            results.put(EXCEPTION, " statusCode : " + statusCode + ", Title : message " + errorDetail);
        } else {
              Severity: Major
              Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java and 1 other location - About 1 hr to fix
              cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java on lines 229..236

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      } else if (statusCode.equals(500)) {
            final String errorDetail = JsonPath.read(returnMessage, ERROR_MESSAGE_PATH);
            results.put(RETURN_RESULT, "  error Message : " + errorDetail);
            results.put(EXCEPTION, " statusCode : " + statusCode + ", Title : message " + errorDetail);
        } else {
              Severity: Major
              Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java and 1 other location - About 1 hr to fix
              cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java on lines 250..257

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 7 locations. Consider refactoring.
              Open

                  @NotNull
    public static Proxy getProxy(@NotNull final String proxyHost, final int proxyPort, @NotNull final String proxyUser, @NotNull final String proxyPassword) {
        if (StringUtilities.isBlank(proxyHost)) {
            return Proxy.NO_PROXY;
        }
              Severity: Major
              Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java and 6 other locations - About 1 hr to fix
              cs-azure/src/main/java/io/cloudslang/content/azure/utils/HttpUtils.java on lines 52..66
              cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/HttpUtils.java on lines 26..40
              cs-microfocus-sitescope/src/main/java/io/cloudslang/content/sitescope/utils/HttpUtils.java on lines 39..53
              cs-microsoft-ad/src/main/java/io/cloudslang/content/microsoftAD/utils/HttpUtils.java on lines 41..55
              cs-office-365/src/main/java/io/cloudslang/content/office365/utils/HttpUtils.java on lines 39..53
              cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/utils/HttpUtils.java on lines 27..41

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 68.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  public static void setSecurityInputs(@NotNull final HttpClientInputs httpClientInputs,
                                         @NotNull final String trustAllRoots,
                                         @NotNull final String x509HostnameVerifier,
                                         @NotNull final String trustKeystore,
                                         @NotNull final String trustPassword,
              Severity: Major
              Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java and 4 other locations - About 50 mins to fix
              cs-microfocus-dca/src/main/java/io/cloudslang/content/dca/utils/Utilities.java on lines 130..143
              cs-microfocus-dca/src/main/java/io/cloudslang/content/dca/utils/Utilities.java on lines 166..179
              cs-microfocus-sitescope/src/main/java/io/cloudslang/content/sitescope/utils/HttpUtils.java on lines 68..81
              cs-microfocus-sitescope/src/main/java/io/cloudslang/content/sitescope/utils/HttpUtils.java on lines 84..97

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (statusCode.equals(401)) {
            results.put(RETURN_RESULT, inputName + " not found, or user unauthorized to perform action");
            results.put(EXCEPTION, "status : " + statusCode + ", Title :  " + inputName + " not found, or user unauthorized to perform action");
        } else if (statusCode.equals(500)) {
              Severity: Minor
              Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java and 1 other location - About 30 mins to fix
              cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java on lines 221..224

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (statusCode.equals(401)) {
            results.put(RETURN_RESULT, inputName + " not found, or user unauthorized to perform action");
            results.put(EXCEPTION, "status : " + statusCode + ", Title :  " + inputName + " not found, or user unauthorized to perform action");
        } else if (statusCode.equals(200) || statusCode.equals(201) && taskStatus.equals(FAILED)) {
              Severity: Minor
              Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java and 1 other location - About 30 mins to fix
              cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java on lines 247..250

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 12 locations. Consider refactoring.
              Open

                  public static void setProxy(@NotNull final HttpClientInputs httpClientInputs,
                                @NotNull final String proxyHost,
                                @NotNull final String proxyPort,
                                @NotNull final String proxyUsername,
                                @NotNull final String proxyPassword) {
              Severity: Major
              Found in cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java and 11 other locations - About 30 mins to fix
              cs-azure/src/main/java/io/cloudslang/content/azure/utils/HttpUtils.java on lines 85..94
              cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/HttpUtils.java on lines 42..51
              cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/HttpUtils.java on lines 86..95
              cs-microfocus-dca/src/main/java/io/cloudslang/content/dca/utils/Utilities.java on lines 119..128
              cs-microfocus-dca/src/main/java/io/cloudslang/content/dca/utils/Utilities.java on lines 155..164
              cs-microfocus-sitescope/src/main/java/io/cloudslang/content/sitescope/utils/HttpUtils.java on lines 56..65
              cs-microsoft-ad/src/main/java/io/cloudslang/content/microsoftAD/utils/HttpUtils.java on lines 173..182
              cs-microsoft-ad/src/main/java/io/cloudslang/content/microsoftAD/utils/HttpUtils.java on lines 184..193
              cs-office-365/src/main/java/io/cloudslang/content/office365/utils/HttpUtils.java on lines 181..190
              cs-office-365/src/main/java/io/cloudslang/content/office365/utils/HttpUtils.java on lines 192..201
              cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/utils/HttpUtils.java on lines 43..52

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status