Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java

Summary

Maintainability
D
2 days
Test Coverage

File OpenshiftService.java has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package io.cloudslang.content.redhat.services;

import com.google.gson.*;
import com.hp.oo.sdk.content.plugin.GlobalSessionObject;
import com.hp.oo.sdk.content.plugin.SerializableSessionObject;
Severity: Minor
Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java - About 2 hrs to fix

    Method processAuthTokenResult has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static void processAuthTokenResult(Map<String, String> httpResults, HttpInput input, SerializableSessionObject sessionCookies, GlobalSessionObject sessionConnectionPool) {

        try {
            String getHtmlResponse = httpResults.get(RETURN_RESULT);
            Document doc = Jsoup.parse(getHtmlResponse);
    Severity: Major
    Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java - About 2 hrs to fix

      Method processHttpGetDeploymentStatusResult has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static void processHttpGetDeploymentStatusResult(Map<String, String> httpResults) {

        //Process the return result output
        String returnResult = httpResults.get(RETURN_RESULT);
        try {
      Severity: Minor
      Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java - About 1 hr to fix

        Method processAuthTokenResult has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public static void processAuthTokenResult(Map<String, String> httpResults, HttpInput input, SerializableSessionObject sessionCookies, GlobalSessionObject sessionConnectionPool) {

        try {
            String getHtmlResponse = httpResults.get(RETURN_RESULT);
            Document doc = Jsoup.parse(getHtmlResponse);
        Severity: Minor
        Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method processHttpGetDeploymentDetailsResult has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static void processHttpGetDeploymentDetailsResult(Map<String, String> httpResults) {

        //Process the return result output
        String returnResult = httpResults.get(RETURN_RESULT);
        try {
        Severity: Minor
        Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java - About 1 hr to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public static void addDeploymentListResults(Map<String, String> httpResults) {
        try {
            if (!(httpResults.get(RETURN_RESULT).isEmpty())) {

                StringBuilder deploymentList = new StringBuilder();
          Severity: Major
          Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java and 3 other locations - About 1 hr to fix
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 169..194
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 197..222
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 224..249

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public static void addPodTemplateListResults(Map<String, String> httpResults) {
        try {
            if (!(httpResults.get(RETURN_RESULT).isEmpty())) {

                StringBuilder podTemplateList = new StringBuilder();
          Severity: Major
          Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java and 3 other locations - About 1 hr to fix
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 142..167
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 197..222
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 224..249

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public static void addRouteListResults(Map<String, String> httpResults) {
        try {
            if (!(httpResults.get(RETURN_RESULT).isEmpty())) {

                StringBuilder routeList = new StringBuilder();
          Severity: Major
          Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java and 3 other locations - About 1 hr to fix
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 142..167
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 169..194
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 197..222

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public static void addTemplateListResults(Map<String, String> httpResults) {
        try {
            if (!(httpResults.get(RETURN_RESULT).isEmpty())) {

                StringBuilder templateList = new StringBuilder();
          Severity: Major
          Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java and 3 other locations - About 1 hr to fix
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 142..167
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 169..194
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 224..249

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (StringUtils.isEmpty(statusCode) || Integer.parseInt(statusCode) < 200 || Integer.parseInt(statusCode) >= 300) {
            if (StringUtils.isEmpty(httpResults.get(EXCEPTION)))
                httpResults.put(EXCEPTION, httpResults.get(RETURN_RESULT));
            httpResults.put(RETURN_CODE, NEGATIVE_RETURN_CODE);
        }
          Severity: Major
          Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java and 2 other locations - About 1 hr to fix
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 46..50
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 91..95

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      if (StringUtils.isEmpty(statusCode) || Integer.parseInt(statusCode) < 200 || Integer.parseInt(statusCode) >= 300) {
                if (StringUtils.isEmpty(httpResults.get(EXCEPTION)))
                    httpResults.put(EXCEPTION, httpResults.get(RETURN_RESULT));
                httpResults.put(RETURN_CODE, NEGATIVE_RETURN_CODE);
            }
          Severity: Major
          Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java and 2 other locations - About 1 hr to fix
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 46..50
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 108..112

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      if (StringUtils.isEmpty(statusCode) || Integer.parseInt(statusCode) < 200 || Integer.parseInt(statusCode) >= 300) {
                if (StringUtils.isEmpty(httpResults.get(EXCEPTION)))
                    httpResults.put(EXCEPTION, httpResults.get(RETURN_RESULT));
                httpResults.put(RETURN_CODE, NEGATIVE_RETURN_CODE);
            }
          Severity: Major
          Found in cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java and 2 other locations - About 1 hr to fix
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 91..95
          cs-openshift/src/main/java/io/cloudslang/content/redhat/services/OpenshiftService.java on lines 108..112

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status