Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java

Summary

Maintainability
D
3 days
Test Coverage

Method readFromFile has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public static List<String> readFromFile(String fileName) {
        final List<String> lines = new ArrayList<>();


        try (final FileInputStream fstream = new FileInputStream(new File(fileName));
Severity: Minor
Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method readFromFile has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static List<String> readFromFile(String fileName) {
        final List<String> lines = new ArrayList<>();


        try (final FileInputStream fstream = new FileInputStream(new File(fileName));
Severity: Major
Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java - About 2 hrs to fix

    Method processLoadException has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static String processLoadException(SQLException e) throws SQLException {
        final String sqlState = e.getSQLState();
        if (sqlState != null && StringUtils.equalsIgnoreCase(sqlState,"s1000")) {
            SQLException f = e;
            StringBuilder s = new StringBuilder();
    Severity: Minor
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method processNullTerminatedString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static String processNullTerminatedString(final String value) {
        if (isEmpty(value)) {
            return "null";
        }
        char[] charArray = value.toCharArray();
    Severity: Minor
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method processDumpException has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static String processDumpException(SQLException sqlException) throws SQLException {
        final String sqlState = sqlException.getSQLState();

        if (sqlState != null && StringUtils.equalsIgnoreCase(sqlState, "s1000")) {
            SQLException f = sqlException;
    Severity: Minor
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static List<String> readFromFile(String fileName) {
        final List<String> lines = new ArrayList<>();


        try (final FileInputStream fstream = new FileInputStream(new File(fileName));
    Severity: Major
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java and 1 other location - About 7 hrs to fix
    cs-database/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java on lines 155..235

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 458.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static String processDumpException(SQLException sqlException) throws SQLException {
        final String sqlState = sqlException.getSQLState();

        if (sqlState != null && StringUtils.equalsIgnoreCase(sqlState, "s1000")) {
            SQLException f = sqlException;
    Severity: Major
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java and 1 other location - About 1 hr to fix
    cs-database/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java on lines 116..131

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static String processLoadException(SQLException e) throws SQLException {
        final String sqlState = e.getSQLState();
        if (sqlState != null && StringUtils.equalsIgnoreCase(sqlState,"s1000")) {
            SQLException f = e;
            StringBuilder s = new StringBuilder();
    Severity: Major
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java and 1 other location - About 1 hr to fix
    cs-database/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java on lines 140..153

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static String processNullTerminatedString(final String value) {
        if (isEmpty(value)) {
            return "null";
        }
        char[] charArray = value.toCharArray();
    Severity: Major
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java and 1 other location - About 1 hr to fix
    cs-database/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java on lines 51..64

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        @NotNull
    public static String computeSessionId(@NotNull final String aString) {
        final byte[] byteData = DigestUtils.sha256(aString.getBytes());
        final StringBuilder sb = new StringBuilder("SQLQuery:");
    Severity: Major
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java and 2 other locations - About 1 hr to fix
    cs-database/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java on lines 94..107
    cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/Utils.java on lines 80..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        @NotNull
    public static String getStrColumns(@NotNull final GlobalSessionObject<Map<String, Object>> globalSessionObject, @NotNull final String strKeyCol) {
        final Map<String, Object> globalMap = globalSessionObject.get();
        if (globalMap.containsKey(strKeyCol) && globalMap.get(strKeyCol) instanceof String) {
            try {
    Severity: Major
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java and 2 other locations - About 1 hr to fix
    cs-database/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java on lines 251..264
    cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/Utils.java on lines 55..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static String toString(SQLException e) {
        String curr = exceptionToString(e) + "\nstate:" + e.getSQLState();
        while ((e = e.getNextException()) != null)
            curr += "\n\n" + exceptionToString(e) + "\nstate:" + e.getSQLState();
        return curr;
    Severity: Minor
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java and 1 other location - About 1 hr to fix
    cs-database/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java on lines 86..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        @NotNull
    public static List<String> getRowsFromGlobalSessionMap(@NotNull final GlobalSessionObject<Map<String, Object>> globalSessionObject, @NotNull final String aKey) {
        final Map<String, Object> globalMap = globalSessionObject.get();
        if (globalMap.containsKey(aKey)) {
            try {
    Severity: Major
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java and 2 other locations - About 55 mins to fix
    cs-database/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java on lines 237..249
    cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/Utils.java on lines 41..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static String exceptionToString(Throwable e) {
        // Print the stack trace into an in memory string
        StringWriter writer = new StringWriter();
        e.printStackTrace(new PrintWriter(writer));
    Severity: Minor
    Found in cs-oracle-cloud-databases/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java and 1 other location - About 30 mins to fix
    cs-database/src/main/java/io/cloudslang/content/database/utils/SQLUtils.java on lines 77..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status