Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/entities/inputs/OCICommonInputs.java

Summary

Maintainability
D
2 days
Test Coverage

File OCICommonInputs.java has 296 lines of code (exceeds 250 allowed). Consider refactoring.
Open



package io.cloudslang.content.oracle.oci.entities.inputs;

import org.jetbrains.annotations.NotNull;
Severity: Minor
Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/entities/inputs/OCICommonInputs.java - About 3 hrs to fix

    OCICommonInputs has 24 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class OCICommonInputs {
    private final String compartmentOcid;
    private final String tenancyOcid;
    private final String userOcid;
    private final String fingerPrint;
    Severity: Minor
    Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/entities/inputs/OCICommonInputs.java - About 2 hrs to fix

      OCICommonInputsBuilder has 24 methods (exceeds 20 allowed). Consider refactoring.
      Open

          public static class OCICommonInputsBuilder {
        private String compartmentOcid = EMPTY;
        private String tenancyOcid = EMPTY;
        private String userOcid = EMPTY;
        private String fingerPrint = EMPTY;
      Severity: Minor
      Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/entities/inputs/OCICommonInputs.java - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static class OCICommonInputsBuilder {
        private String compartmentOcid = EMPTY;
        private String tenancyOcid = EMPTY;
        private String userOcid = EMPTY;
        private String fingerPrint = EMPTY;
        Severity: Major
        Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/entities/inputs/OCICommonInputs.java and 1 other location - About 1 day to fix
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/entities/NutanixCommonInputs.java on lines 195..374

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 612.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @java.beans.ConstructorProperties({"compartmentOcid", "tenancyOcid", "userOcid", "fingerPrint", "privateKeyData", "privateKeyFile", "apiVersion", "region", "proxyHost", "proxyPort", "proxyUsername", "proxyPassword", "connectTimeout", "socketTimeout", "keepAlive", "connectionsMaxPerRoot", "connectionsMaxTotal", "instanceId", "vnicId", "volumeId", "availabilityDomain", "page", "limit"})
    private OCICommonInputs(String compartmentOcid, String tenancyOcid, String userOcid, String fingerPrint, String privateKeyData, String privateKeyFile, String apiVersion, String region, String proxyHost, String proxyPort, String proxyUsername, String proxyPassword, String connectTimeout, String socketTimeout, String keepAlive, String connectionsMaxPerRoot, String connectionsMaxTotal, String instanceId, String vnicId, String volumeId, String availabilityDomain, String page, String limit) {
        this.compartmentOcid = compartmentOcid;
        this.tenancyOcid = tenancyOcid;
        this.userOcid = userOcid;
        Severity: Major
        Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/entities/inputs/OCICommonInputs.java and 1 other location - About 5 hrs to fix
        cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/entities/NutanixCommonInputs.java on lines 36..72

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 314.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status