Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java

Summary

Maintainability
D
2 days
Test Coverage

Method createInstanceRequestBody has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static String createInstanceRequestBody(@NotNull final OCICreateInstanceInputs createInstancesInputs) {
        String requestBody = EMPTY;
        ObjectMapper createInstanceMapper = new ObjectMapper();
        CreateInstanceRequestBody createInstanceRequestBody = new CreateInstanceRequestBody();
        CreateInstanceRequestBody.Metadata metadata = createInstanceRequestBody.new Metadata();
Severity: Major
Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java - About 3 hrs to fix

    File InstanceImpl.java has 281 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    

package io.cloudslang.content.oracle.oci.services;
    Severity: Minor
    Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java - About 2 hrs to fix

      Method createInstanceRequestBody has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          private static String createInstanceRequestBody(@NotNull final OCICreateInstanceInputs createInstancesInputs) {
        String requestBody = EMPTY;
        ObjectMapper createInstanceMapper = new ObjectMapper();
        CreateInstanceRequestBody createInstanceRequestBody = new CreateInstanceRequestBody();
        CreateInstanceRequestBody.Metadata metadata = createInstanceRequestBody.new Metadata();
      Severity: Minor
      Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateInstanceRequestBody has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static String updateInstanceRequestBody(@NotNull final OCIUpdateInstanceInputs ociUpdateInstanceInputs) {
        String requestBody = EMPTY;
        ObjectMapper updateInstanceMapper = new ObjectMapper();
        UpdateInstanceRequestBody updateInstanceRequestBody = new UpdateInstanceRequestBody();
        UpdateInstanceRequestBody.AgentConfig agentConfig = updateInstanceRequestBody.new AgentConfig();
      Severity: Minor
      Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java - About 1 hr to fix

        Method updateInstanceRequestBody has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private static String updateInstanceRequestBody(@NotNull final OCIUpdateInstanceInputs ociUpdateInstanceInputs) {
        String requestBody = EMPTY;
        ObjectMapper updateInstanceMapper = new ObjectMapper();
        UpdateInstanceRequestBody updateInstanceRequestBody = new UpdateInstanceRequestBody();
        UpdateInstanceRequestBody.AgentConfig agentConfig = updateInstanceRequestBody.new AgentConfig();
        Severity: Minor
        Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    public static Map<String, String> terminateInstance(@NotNull final OCITerminateInstanceInputs ociTerminateInstanceInputs) throws Exception {

        final HttpClientInputs httpClientInputs = new HttpClientInputs();
        httpClientInputs.setUrl(getInstanceDetailsUrl(ociTerminateInstanceInputs.getCommonInputs().getRegion(), ociTerminateInstanceInputs.getCommonInputs().getInstanceId()));
        Severity: Major
        Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java and 1 other location - About 2 hrs to fix
        cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java on lines 230..244

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 136.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    public static Map<String, String> instanceAction(@NotNull final OCIInstanceActionInputs ociInstanceActionInputs) throws Exception {

        final HttpClientInputs httpClientInputs = new HttpClientInputs();
        httpClientInputs.setUrl(getInstanceDetailsUrl(ociInstanceActionInputs.getCommonInputs().getRegion(), ociInstanceActionInputs.getCommonInputs().getInstanceId()));
        Severity: Major
        Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java and 1 other location - About 2 hrs to fix
        cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java on lines 214..228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 136.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @NotNull
    public static Map<String, String> createInstance(@NotNull final OCICreateInstanceInputs createInstancesInputs)
            throws Exception {

        final HttpClientInputs httpClientInputs = new HttpClientInputs();
        Severity: Major
        Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java and 1 other location - About 1 hr to fix
        cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/VolumeImpl.java on lines 34..48

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            @NotNull
    private static SignerImpl.RequestSigner getRequestSigner(OCICommonInputs ociCommonInputs) {
        String apiKey = (ociCommonInputs.getTenancyOcid() + FORWARD_SLASH
                + ociCommonInputs.getUserOcid() + FORWARD_SLASH
                + ociCommonInputs.getFingerPrint());
        Severity: Major
        Found in cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/InstanceImpl.java and 2 other locations - About 50 mins to fix
        cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/VnicImpl.java on lines 64..71
        cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/services/VolumeImpl.java on lines 24..32

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status