CloudSlang/cs-actions

View on GitHub
cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/utils/HttpUtils.java

Summary

Maintainability
C
1 day
Test Coverage

Method getQueryParams has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public static String getQueryParams(@NotNull final String availabilityDomain, @NotNull final String compartmentId, @NotNull final String displayName, @NotNull final String limit, @NotNull final String page, @NotNull final String sortBy, @NotNull final String sortOrder, @NotNull final String instanceName) {

    Method setConnectionParameters has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static void setConnectionParameters(HttpClientInputs httpClientInputs,
                                                   @NotNull final String connectTimeout,
                                                   @NotNull final String socketTimeout,
                                                   @NotNull final String keepAlive,
                                                   @NotNull final String connectionsMaxPerRoot,

      Method getQueryParams has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static String getQueryParams(@NotNull final String availabilityDomain, @NotNull final String compartmentId, @NotNull final String instanceId, @NotNull final String page, @NotNull final String limit, @NotNull final String vnicId) {

        Method setProxy has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static void setProxy(@org.jetbrains.annotations.NotNull final HttpClientInputs httpClientInputs,
                                        @org.jetbrains.annotations.NotNull final String proxyHost,
                                        @org.jetbrains.annotations.NotNull final String proxyPort,
                                        @org.jetbrains.annotations.NotNull final String proxyUsername,
                                        @org.jetbrains.annotations.NotNull final String proxyPassword) {

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              @NotNull
              public static Map<String, String> getFailureResults(@NotNull String inputName, @NotNull Integer statusCode, @NotNull String throwable) {
                  Map<String, String> results = new HashMap();
                  results.put("returnCode", "-1");
                  results.put("statusCode", statusCode.toString());
          cs-azure/src/main/java/io/cloudslang/content/azure/utils/HttpUtils.java on lines 193..206
          cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/HttpUtils.java on lines 131..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 112.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

              @NotNull
              public static Map<String, String> getOperationResults(@NotNull final Map<String, String> result,
                                                                    @NotNull final String successMessage,
                                                                    final String failureMessage,
                                                                    final String document) {
          cs-azure/src/main/java/io/cloudslang/content/azure/utils/HttpUtils.java on lines 104..120
          cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/HttpUtils.java on lines 68..84
          cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java on lines 76..92
          cs-office-365/src/main/java/io/cloudslang/content/office365/utils/HttpUtils.java on lines 281..297

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 7 locations. Consider refactoring.
          Open

              @org.jetbrains.annotations.NotNull
              public static Proxy getProxy(@org.jetbrains.annotations.NotNull final String proxyHost, final int proxyPort, @org.jetbrains.annotations.NotNull final String proxyUser, @org.jetbrains.annotations.NotNull final String proxyPassword) {
                  if (StringUtilities.isBlank(proxyHost)) {
                      return Proxy.NO_PROXY;
                  }
          cs-azure/src/main/java/io/cloudslang/content/azure/utils/HttpUtils.java on lines 52..66
          cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/HttpUtils.java on lines 26..40
          cs-microfocus-sitescope/src/main/java/io/cloudslang/content/sitescope/utils/HttpUtils.java on lines 39..53
          cs-microsoft-ad/src/main/java/io/cloudslang/content/microsoftAD/utils/HttpUtils.java on lines 41..55
          cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java on lines 34..48
          cs-office-365/src/main/java/io/cloudslang/content/office365/utils/HttpUtils.java on lines 39..53

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (Map.Entry<String, String> entry : map.entrySet()) {
                      if (!isEmpty(entry.getKey())) {
                          queryParams = queryParams.append((entry.getValue() + entry.getKey()) + AND);
                      }
                  }
          cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/utils/HttpUtils.java on lines 168..172

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (Map.Entry<String, String> entry : map.entrySet()) {
                      if (!isEmpty(entry.getKey())) {
                          queryParams = queryParams.append((entry.getValue() + entry.getKey()) + AND);
                      }
                  }
          cs-oracle-cloud/src/main/java/io/cloudslang/content/oracle/oci/utils/HttpUtils.java on lines 147..151

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              public static void setConnectionParameters(HttpClientInputs httpClientInputs,
                                                         @NotNull final String connectTimeout,
                                                         @NotNull final String socketTimeout,
                                                         @NotNull final String keepAlive,
                                                         @NotNull final String connectionsMaxPerRoot,
          cs-microsoft-ad/src/main/java/io/cloudslang/content/microsoftAD/utils/HttpUtils.java on lines 195..206
          cs-office-365/src/main/java/io/cloudslang/content/office365/utils/HttpUtils.java on lines 203..214

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 12 locations. Consider refactoring.
          Open

              public static void setProxy(@org.jetbrains.annotations.NotNull final HttpClientInputs httpClientInputs,
                                          @org.jetbrains.annotations.NotNull final String proxyHost,
                                          @org.jetbrains.annotations.NotNull final String proxyPort,
                                          @org.jetbrains.annotations.NotNull final String proxyUsername,
                                          @org.jetbrains.annotations.NotNull final String proxyPassword) {
          cs-azure/src/main/java/io/cloudslang/content/azure/utils/HttpUtils.java on lines 85..94
          cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/HttpUtils.java on lines 42..51
          cs-hashicorp-terraform/src/main/java/io/cloudslang/content/hashicorp/terraform/utils/HttpUtils.java on lines 86..95
          cs-microfocus-dca/src/main/java/io/cloudslang/content/dca/utils/Utilities.java on lines 119..128
          cs-microfocus-dca/src/main/java/io/cloudslang/content/dca/utils/Utilities.java on lines 155..164
          cs-microfocus-sitescope/src/main/java/io/cloudslang/content/sitescope/utils/HttpUtils.java on lines 56..65
          cs-microsoft-ad/src/main/java/io/cloudslang/content/microsoftAD/utils/HttpUtils.java on lines 173..182
          cs-microsoft-ad/src/main/java/io/cloudslang/content/microsoftAD/utils/HttpUtils.java on lines 184..193
          cs-nutanix-prism/src/main/java/io/cloudslang/content/nutanix/prism/utils/HttpUtils.java on lines 50..59
          cs-office-365/src/main/java/io/cloudslang/content/office365/utils/HttpUtils.java on lines 181..190
          cs-office-365/src/main/java/io/cloudslang/content/office365/utils/HttpUtils.java on lines 192..201

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status