Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java

Summary

Maintainability
D
1 day
Test Coverage

FSUtil has 45 methods (exceeds 20 allowed). Consider refactoring.
Open

public class FSUtil {
    static final String CLASS_FILE_SUFFIX = ".class";
    static final int BUFFER_SIZE = 16384; // 16 * 1024

    /**
Severity: Minor
Found in cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java - About 6 hrs to fix

    File FSUtil.java has 364 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright 2021-2024 Open Text
 * This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
    Severity: Minor
    Found in cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java - About 4 hrs to fix

      Method downloadToTempFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static File downloadToTempFile(String url) {
        URL fileURL;
        try {
            fileURL = new URL(url);
        }
      Severity: Minor
      Found in cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java - About 1 hr to fix

        Method recursiveCopy has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static void recursiveCopy(File src, File dest) throws IOException {
        // Copy directory
        if (src.isDirectory()) {
            if (!dest.exists()) {
                dest.mkdirs();
        Severity: Minor
        Found in cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        TODO found
        Open

             * TODO: hmm.... maybe this just makes debugging harder?
        Severity: Minor
        Found in cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java by fixme

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static String joinRelativePaths(String base, String... pathElements) {
        File joined = new File(base);

        for (String element : pathElements)
            joined =  new File(joined, element);
        Severity: Minor
        Found in cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java and 1 other location - About 30 mins to fix
        cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java on lines 685..692

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static String joinPaths(String base, String... pathElements) throws IOException {
        File joined = new File(base);

        for (String element : pathElements)
            joined =  new File(joined, element);
        Severity: Minor
        Found in cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java and 1 other location - About 30 mins to fix
        cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java on lines 702..709

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    for (byte b : digestBytes) {
                hash.append(Integer.toHexString((b & 0xFF) | 0x100).toLowerCase().substring(1,3));
            }
        Severity: Minor
        Found in cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/FSUtil.java and 1 other location - About 30 mins to fix
        cs-filesystem/src/main/java/io/cloudslang/content/filesystem/services/MD5SumService.java on lines 63..65

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status