Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java

Summary

Maintainability
D
2 days
Test Coverage

Method copyFromRemoteToLocal has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    protected boolean copyFromRemoteToLocal(String srcPath, String destPath){
        FileOutputStream fileOutputStream = null;

        try {
Severity: Minor
Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method copyFromRemoteToLocal has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected boolean copyFromRemoteToLocal(String srcPath, String destPath){
        FileOutputStream fileOutputStream = null;

        try {
Severity: Major
Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java - About 3 hrs to fix

    Method copyFromLocalToRemote has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected boolean copyFromLocalToRemote(String srcPath, String destPath){
        FileInputStream fileInputStream = null;

        try {
    Severity: Major
    Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java - About 2 hrs to fix

      File SCPCopier.java has 255 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
 * Copyright 2021-2024 Open Text
 * This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
      Severity: Minor
      Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java - About 2 hrs to fix

        Method copyFromLocalToRemote has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            protected boolean copyFromLocalToRemote(String srcPath, String destPath){
        FileInputStream fileInputStream = null;

        try {
        Severity: Minor
        Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method establishPrivateKeyFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            protected void establishPrivateKeyFile(KeyFile keyFile, JSch jsch, Session session, boolean usesSrcPrivateKeyFile) throws JSchException {
        if (keyFile == null) {
            if (usesSrcPrivateKeyFile){
                session.setPassword(remoteSecureCopyInputs.getSrcPassword());
            }
        Severity: Minor
        Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return true;
        Severity: Major
        Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java - About 30 mins to fix

            Method checkAck has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private int checkAck(InputStream in) throws IOException {
        int b = in.read();
        // b may be 0 for success,
        //          1 for error,
        //          2 for fatal error,
            Severity: Minor
            Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    switch (policy.toLowerCase(Locale.ENGLISH)){
            case KNOWN_HOSTS_ALLOW:
                session.setConfig("StrictHostKeyChecking", "no");
                break;
            case KNOWN_HOSTS_STRICT:
            Severity: Major
            Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java and 1 other location - About 2 hrs to fix
            cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPService.java on lines 383..404

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 132.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        while (true) {
                int len = fileInputStream.read(buf, 0, buf.length);
                if (len <= 0)
                    break;
                out.write(buf, 0, len);
            Severity: Minor
            Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SCPCopier.java and 1 other location - About 40 mins to fix
            cs-rft/src/main/java/io/cloudslang/content/rft/remote_copy/ScpCopier.java on lines 449..455

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status