Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java

Summary

Maintainability
D
2 days
Test Coverage

Method performSFTPOperation has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void performSFTPOperation(IHasFTPOperation sftpInputs, SFTPOperation sftpOperation, SFTPCopier sftpCopier, String sessionId) throws Exception {
        if (sftpOperation == SFTPOperation.GET) {
            sftpCopier.setSftpInputs(sftpInputs);
            try {
                CompletableFuture.runAsync(() -> {
Severity: Major
Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java - About 5 hrs to fix

    Method performSFTPOperation has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        private void performSFTPOperation(IHasFTPOperation sftpInputs, SFTPOperation sftpOperation, SFTPCopier sftpCopier, String sessionId) throws Exception {
        if (sftpOperation == SFTPOperation.GET) {
            sftpCopier.setSftpInputs(sftpInputs);
            try {
                CompletableFuture.runAsync(() -> {
    Severity: Minor
    Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public Map<String, String> execute(IHasFTPOperation sftpInputs, SFTPOperation sftpOperation) {
        SFTPCopier sftpCopier = null;
        String sessionId = EMPTY_STRING;
        boolean providerAdded = addSecurityProvider();
    Severity: Minor
    Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public Map<String, String> execute(IHasFTPOperation sftpInputs, SFTPOperation sftpOperation) {
        SFTPCopier sftpCopier = null;
        String sessionId = EMPTY_STRING;
        boolean providerAdded = addSecurityProvider();
    Severity: Minor
    Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return getSuccessResultsMap(CREATE_DIR_SUCCESS_DESC);
      Severity: Major
      Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return getSuccessResultsMap(SUCCESS_DESC);
        Severity: Major
        Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return getSuccessResultsMap(DELETE_DIR_SUCCESS_DESC);
          Severity: Major
          Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return results;
            Severity: Major
            Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java - About 30 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      } else if (sftpOperation == SFTPOperation.GET_CHILDREN) {
            sftpCopier.setSftpInputs(sftpInputs);

            try {
                CompletableFuture.runAsync(() -> {
              Severity: Major
              Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java and 2 other locations - About 1 hr to fix
              cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java on lines 107..121
              cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java on lines 94..107

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (sftpOperation == SFTPOperation.GET) {
            sftpCopier.setSftpInputs(sftpInputs);
            try {
                CompletableFuture.runAsync(() -> {
                    try {
              Severity: Major
              Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java and 2 other locations - About 1 hr to fix
              cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java on lines 121..135
              cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java on lines 107..121

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      } else if (sftpOperation == SFTPOperation.PUT) {
            sftpCopier.setSftpInputs(sftpInputs);

            try {
                CompletableFuture.runAsync(() -> {
              Severity: Major
              Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java and 2 other locations - About 1 hr to fix
              cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java on lines 121..135
              cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java on lines 94..107

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  private boolean addSecurityProvider() {
        boolean providerAdded = false;
        Provider provider = Security.getProvider("BC");
        if (provider == null) {
            providerAdded = true;
              Severity: Minor
              Found in cs-rft/src/main/java/io/cloudslang/content/rft/services/SFTPService.java and 1 other location - About 45 mins to fix
              cs-ssh/src/main/java/io/cloudslang/content/ssh/services/actions/SSHShellAbstract.java on lines 46..54

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status