Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java

Summary

Maintainability
D
2 days
Test Coverage

File SharepointService.java has 447 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright 2024 Open Text
 * This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
Severity: Minor
Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java - About 6 hrs to fix

    SharepointService has 28 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class SharepointService {

    public static String encodeFileName(String fileName) throws URISyntaxException {
        return new URI(null, null, fileName, null).toASCIIString();
    }
    Severity: Minor
    Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java - About 3 hrs to fix

      Method processHttpGetEntitiesFromDrive has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static void processHttpGetEntitiesFromDrive(Map<String, String> httpResults, String exceptionMessage, String entitiesType) throws JsonProcessingException {

        processHttpResult(httpResults, exceptionMessage);

        if (!httpResults.get(STATUS_CODE).equals(STATUS_CODE_200))
      Severity: Minor
      Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java - About 1 hr to fix

        Method processHostWithQuery has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public static String processHostWithQuery(List<String> ids, String searchText, String optionalParameters) throws Utils.HostException {
        boolean found = false;
        for(String id:ids){
            if (!id.isEmpty()){
                if(!found)
        Severity: Minor
        Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method processHost has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public static String processHost(List<String> ids, String parentItemId) throws Utils.HostException {

        // verify that there is no more than 1 input
        boolean found = false;
        for(String id:ids){
        Severity: Minor
        Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method processHostWithQuery has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static String processHostWithQuery(List<String> ids, String searchText, String optionalParameters) throws Utils.HostException {
        boolean found = false;
        for(String id:ids){
            if (!id.isEmpty()){
                if(!found)
        Severity: Minor
        Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java - About 1 hr to fix

          Method processHostDeleteFolder has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public static String processHostDeleteFolder(List<String> ids, String folderName) throws Utils.HostException {
        boolean found = false;

        for(String id:ids){
            if(!id.isEmpty()){
          Severity: Minor
          Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static void processHttpDeleteFile(Map<String, String> httpResults, String exceptionMessage) {

        processHttpResult(httpResults, exceptionMessage);

        String statusCode = httpResults.get(STATUS_CODE);
          Severity: Minor
          Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java and 1 other location - About 40 mins to fix
          cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java on lines 533..543

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static void processHttpDeleteFolder(Map<String, String> httpResults, String exceptionMessage) {

        processHttpResult(httpResults, exceptionMessage);

        String statusCode = httpResults.get(STATUS_CODE);
          Severity: Minor
          Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java and 1 other location - About 40 mins to fix
          cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java on lines 545..555

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for(String id:ids){
            if (!id.isEmpty()){
                if(!found)
                    found=true;
                else
          Severity: Minor
          Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java and 1 other location - About 30 mins to fix
          cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java on lines 559..566

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for(String id:ids){
            if (!id.isEmpty()){
                if(!found)
                    found=true;
                else
          Severity: Minor
          Found in cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java and 1 other location - About 30 mins to fix
          cs-sharepoint/src/main/java/io/cloudslang/content/sharepoint/services/SharepointService.java on lines 438..445

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status