Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java

Summary

Maintainability
C
1 day
Test Coverage

Method imageConvert has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public static String imageConvert(String sourcePath, String dataPath, String lang, String dpi, String textBlocks, String deskew, String fromPage, String toPage, String pageIndex)
            throws Exception {
        StringBuilder result = new StringBuilder();
        List<File> fileList = null;
        String destination = sourcePath.substring(0, sourcePath.lastIndexOf(File.separator)) + File.separator;
Severity: Minor
Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method convertPdfToImage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private static List<File> convertPdfToImage(File file, String destination, String dpi, String fromPage,
                                                String toPage, String pageIndex) throws Exception {
        if (file.exists()) {
            PDDocument doc = PDDocument.load(file);
            PDFRenderer renderer = new PDFRenderer(doc);
Severity: Minor
Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method imageConvert has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static String imageConvert(String sourcePath, String dataPath, String lang, String dpi, String textBlocks, String deskew, String fromPage, String toPage, String pageIndex)
            throws Exception {
        StringBuilder result = new StringBuilder();
        List<File> fileList = null;
        String destination = sourcePath.substring(0, sourcePath.lastIndexOf(File.separator)) + File.separator;
Severity: Minor
Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java - About 1 hr to fix

    Method imageConvert has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static String imageConvert(String sourcePath, String dataPath, String lang, String dpi, String textBlocks, String deskew, String fromPage, String toPage, String pageIndex)
    Severity: Major
    Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java - About 1 hr to fix

      Method iteration has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private static List<File> iteration(String destination, Integer dpi, PDFRenderer renderer, List<File> fileList,
                                        String fileName, Integer fromPage, Integer toPage, String pageIndex)
      Severity: Major
      Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java - About 1 hr to fix

        Method fileCreation has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private static void fileCreation(String destination, Integer dpi, PDFRenderer renderer, List<File> fileList,
                                     String fileName, Integer i) throws IOException {
        Severity: Minor
        Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java - About 45 mins to fix

          Method convertPdfToImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private static List<File> convertPdfToImage(File file, String destination, String dpi, String fromPage,
                                                String toPage, String pageIndex) throws Exception {
          Severity: Minor
          Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java - About 45 mins to fix

            Method iteration has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private static List<File> iteration(String destination, Integer dpi, PDFRenderer renderer, List<File> fileList,
                                        String fileName, Integer fromPage, Integer toPage, String pageIndex)
            throws IOException {
        if (!pageIndex.equals(EMPTY)) {
            final String[] arrSplit = pageIndex.split(COMMA);
            Severity: Minor
            Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                for (File image : fileList) {
                        outputArray.add(OcrService.extractTextFromImage(image.getAbsolutePath(), dataPath, lang, textBlocks,
                                deskew));
                        FileUtils.forceDelete(image);
                    }
            Severity: Minor
            Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java and 1 other location - About 30 mins to fix
            cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java on lines 61..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                for (File image : fileList) {
                        result.append(OcrService.extractTextFromImage(image.getAbsolutePath(), dataPath, lang, textBlocks,
                                deskew));
                        FileUtils.forceDelete(image);
                    }
            Severity: Minor
            Found in cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java and 1 other location - About 30 mins to fix
            cs-tesseract/src/main/java/io/cloudslang/content/tesseract/services/PdfService.java on lines 53..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status