Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java

Summary

Maintainability
F
3 days
Test Coverage

Method toXML has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public static String toXML(String val) {
        if (val != null && !val.isEmpty()) {
            int length = val.length();
            StringBuilder buf = new StringBuilder();
Severity: Minor
Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

StringUtils has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

public class StringUtils {
    public static final String REQUIRED_INPUT_MSG = "Input '%s' is required, but was not found.";
    public static final String XML_AMP = "&";
    public static final String XML_QUOTE = """;
    public static final String XML_LESS = "<";
Severity: Minor
Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java - About 2 hrs to fix

    File StringUtils.java has 272 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright 2021-2024 Open Text
 * This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
    Severity: Minor
    Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java - About 2 hrs to fix

      Method resolveRequiredLong has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public static long resolveRequiredLong(String name, String value, boolean positiveOnly) throws IllegalArgumentException {
        if (isNull(value)) {
            if (positiveOnly) {
                throw new IllegalArgumentException(name + " input is required.  Valid values are positive integers.");
            } else {
      Severity: Minor
      Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method resolveRequiredInteger has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public static int resolveRequiredInteger(String name, String value, boolean positiveOnly) throws IllegalArgumentException {
        if (isNull(value)) {
            if (positiveOnly) {
                throw new IllegalArgumentException(name + " input is required.  Valid values are positive integers.");
            } else {
      Severity: Minor
      Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method toXML has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static String toXML(String val) {
        if (val != null && !val.isEmpty()) {
            int length = val.length();
            StringBuilder buf = new StringBuilder();
      Severity: Minor
      Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java - About 1 hr to fix

        Method resolveOptionalLong has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public static Long resolveOptionalLong(String name, String value, Long def, boolean positiveOnly) throws IllegalArgumentException {
        if (isNull(value)) {
            return def;
        } else {
            try {
        Severity: Minor
        Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method resolveOptionalInteger has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public static Integer resolveOptionalInteger(String name, String value, Integer def, boolean positiveOnly) throws IllegalArgumentException {
        if (isNull(value)) {
            return def;
        } else {
            try {
        Severity: Minor
        Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                    if (codepoint > 127) {
                                buf.append("&#x");
                                buf.append(Integer.toHexString(codepoint).toUpperCase());
                                buf.append(";");
                                if (Character.isSupplementaryCodePoint(codepoint)) {
        Severity: Major
        Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else {
            try {
                Integer retVal = Integer.parseInt(value);
                if (positiveOnly && retVal < 0) {
                    throw new IllegalArgumentException("Input '" + name + "' must be an positive integer.");
          Severity: Major
          Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java and 1 other location - About 1 hr to fix
          cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java on lines 89..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else {
            try {
                int retVal = Integer.parseInt(value);
                if (positiveOnly && retVal < 0) {
                    throw new IllegalArgumentException("Input '" + name + "' must be an positive integer.");
          Severity: Major
          Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java and 1 other location - About 1 hr to fix
          cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java on lines 160..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else {
            try {
                Long retVal = Long.parseLong(value);
                if (positiveOnly && retVal < 0L) {
                    throw new IllegalArgumentException("Input '" + name + "' must be an positive long.");
          Severity: Major
          Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java and 1 other location - About 1 hr to fix
          cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java on lines 118..133

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else {
            try {
                long retVal = Long.parseLong(value);
                if (positiveOnly && retVal < 0L) {
                    throw new IllegalArgumentException("Input '" + name + "' must be an positive integer.");
          Severity: Major
          Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java and 1 other location - About 1 hr to fix
          cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java on lines 185..200

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public static String replaceInvalidXMLCharacters(String s) {
        List<String> list = new ArrayList();
        list.add("\u0000");

        String c;
          Severity: Major
          Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java and 1 other location - About 1 hr to fix
          cs-active-directory/src/main/java/io/cloudslang/content/active_directory/utils/ResultUtils.java on lines 47..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else if ("true".equalsIgnoreCase(value)) {
            return true;
        } else if ("false".equalsIgnoreCase(value)) {
            return false;
        } else {
          Severity: Minor
          Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java and 1 other location - About 35 mins to fix
          cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java on lines 68..74

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else if ("true".equalsIgnoreCase(value)) {
            return true;
        } else if ("false".equalsIgnoreCase(value)) {
            return false;
        } else {
          Severity: Minor
          Found in cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java and 1 other location - About 35 mins to fix
          cs-winrm/src/main/java/io/cloudslang/content/winrm/utils/StringUtils.java on lines 144..150

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status