Sign upLogin

CloudSlang/cs-actions

View on GitHub
Star
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java

Summary

Maintainability
B
5 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void testSelectElementList() {
        String xPathQuery = "//subelement";
        String delimiter = ",";
        String expectedResult = "<subelement attr=\"toDelete\">Sub2</subelement>,<subelement attr=\"toDelete\">Sub3</subelement>";
Severity: Major
Found in cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java and 1 other location - About 1 hr to fix
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 106..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void testSelectAttributeList() {
        String xPathQuery = "//root/@*";
        String delimiter = ",";
        String expectedResult = "someid=\"5\"";
Severity: Major
Found in cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java and 1 other location - About 1 hr to fix
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 94..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    @Test
    public void testNotFoundNode() {
        String xPathQuery = "/root/element1/subelement";
        String expectedResult = "No match found";
Severity: Major
Found in cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java and 3 other locations - About 55 mins to fix
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 72..81
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 83..92
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 118..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    @Test
    public void testNotFoundValue() {
        String xPathQuery = "/root/element1/@id";
        String expectedResult = "No match found";
Severity: Major
Found in cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java and 3 other locations - About 55 mins to fix
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 72..81
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 83..92
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 129..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    @Test
    public void testSelectNode() {
        String xPathQuery = "/root/element3/subelement";
        String expectedResult = "<subelement attr=\"toDelete\">Sub3</subelement>";
Severity: Major
Found in cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java and 3 other locations - About 55 mins to fix
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 72..81
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 118..127
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 129..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    @Test
    public void testSelectValue() {
        String xPathQuery = "/root/element3/subelement";
        String expectedResult = "Sub3";
Severity: Major
Found in cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java and 3 other locations - About 55 mins to fix
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 83..92
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 118..127
cs-xml/src/test/java/io/cloudslang/content/xml/actions/XpathQueryTest.java on lines 129..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status