CloudSlang/score

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    @Bean(name = "externalPythonExecutorService")
    public PythonRuntimeService externalPythonExecutorService() {
        Integer pythonProcessPermits = Integer.getInteger("python.concurrent.execution.permits", 30);
        Integer pythonTestingProcessPermits = Integer.getInteger("python.testing.concurrent.execution.permits", 10);
        return new ExternalPythonExecutorServiceImpl(new Semaphore(pythonProcessPermits), new Semaphore(pythonTestingProcessPermits));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    @Override
    @Transactional
    public int joinFinishedMiBranches(int bulkSize) {
        // 1. Find all suspended executions that have all their branches ended
        PageRequest pageRequest = PageRequest.of(0, bulkSize);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (logger.isInfoEnabled()) logger.info("Partition group [" + groupName + "] was created, with group size "+groupSize+", and timeThreshold "+timeThreshold+", and sizeThreshold "+sizeThreshold);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    @Override
    @Transactional
    public int joinFinishedSplits(int bulkSize) {

        // 1. Find all suspended executions that have all their branches ended

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (logger.isInfoEnabled()) logger.info("Partition group [" + groupName + "] was updated, with group size "+groupSize+", and timeThreshold "+timeThreshold+", and sizeThreshold "+sizeThreshold);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    private List<ExecutionMessage> filterToPersistMessages(List<ExecutionMessage> messages) {
        List<ExecutionMessage> result = new ArrayList<>();
        for (ExecutionMessage msg : messages) {
            if (msg.isStepPersist()) {
                result.add(msg);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    protected List<Message> filerToPersistMessages(List<Message> messages) {
        List<Message> result = new ArrayList<>();
        // either a split message or a FINISHED persisted messages
        for (Message msg : messages) {
            if (shouldKeepMessageForShrink(msg)) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    private ProcessBuilder preparePythonProcessForEval(String pythonPath, String evalPyCode) {
        // Must make sure that the eval.py evalPyCode does not contain the " character in its contents
        // otherwise an error will be thrown when running python -c "import json\nimport sys..."
        // code from eval.py separated using \n character
        // Also do not use comments for the same reason in eval.py

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    private ProcessBuilder preparePythonProcessForEval(String pythonPath, String evalPyCode) {
        // Must make sure that the eval.py evalPyCode does not contain the " character in its contents
        // otherwise an error will be thrown when running python -c "import json\nimport sys..."
        // code from eval.py separated using \n character
        // Also do not use comments for the same reason in eval.py

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    private Serializable resolveJythonObjectToJavaForEval(PyObject value, String expression) {
        String errorMessage =
                "Evaluation result for a Python expression should be serializable:\n" +
                        "\tConversion failed for '" + expression + "' (" + value + ").\n";
        return resolveJythonObjectToJava(value, errorMessage);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    @Override
    public void finishGetMessages() {
        if (logger.isDebugEnabled()) {
            logger.debug("In SynchronizationManager.finishGetMessages()");
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    @Override
    public void startGetMessages() {
        if (logger.isDebugEnabled()) {
            logger.debug("In SynchronizationManager.startGetMessages()");
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    private Serializable resolveJythonObjectToJavaEval(PyObject value, String expression) {
        String errorMessage =
                "Evaluation result for a Python expression should be serializable:\n" +
                        "\tConversion failed for '" + expression + "' (" + value + ").\n";
        return resolveJythonObjectToJava(value, errorMessage);

• Read up
  Read up

Avoid too many return statements within this method.

Open

        if (startTime != null ? !startTime.equals(that.startTime) : that.startTime != null) return false;

Avoid too many return statements within this method.

Open

        if (triggeredBy != null ? !triggeredBy.equals(that.triggeredBy) : that.triggeredBy != null) return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

        if (installPath != null ? !installPath.equals(that.installPath) : that.installPath != null) return false;

Avoid too many return statements within this method.

Open

        return !(versionId != null ? !versionId.equals(that.versionId) : that.versionId != null);

Avoid too many return statements within this method.

Open

        if (pauseReason != that.pauseReason) return false;