Sign upLogin

Cloudstek/mollie-php-api

View on GitHub
Star

Showing 53 of 53 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Mollie\API\Resource;

use Mollie\API\Model\Issuer;
Severity: Major
Found in src/Resource/IssuerResource.php and 1 other location - About 3 hrs to fix
src/Resource/MethodResource.php on lines 1..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 159.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Mollie\API\Resource;

use Mollie\API\Model\Method;
Severity: Major
Found in src/Resource/MethodResource.php and 1 other location - About 3 hrs to fix
src/Resource/IssuerResource.php on lines 1..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 159.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function parseData has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseData($name, $value)
    {
        if (!empty($value)) {
            if (preg_match('/.+(Datetime|Date)$/', $name)) {
                // ISO 8601 Date
Severity: Minor
Found in src/Model/Base/ModelBase.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method testCreateRecurringCustomerPayment has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testCreateRecurringCustomerPayment()
    {
        // Mock the payment
        $paymentMock = $this->getPayment();
Severity: Major
Found in tests/Customer/Payment/CustomerPaymentCreateTest.php - About 2 hrs to fix

    Function assertModel has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function assertModel(ModelBase $model, $reference, array $mapping)
    {
        foreach ($mapping as $k => $v) {
            $k = is_int($k) ? $v : $k; // Handle non-associative arrays
    Severity: Minor
    Found in tests/TestCase/ResourceTestCase.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getMultiPageRequestMock has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getMultiPageRequestMock(Mollie $api, $data, $endpoint)
    {
        // Epic math skills
        $totalCount = count($data);
        $dataPageOne = array_slice($data, 0, floor($totalCount / 2));
    Severity: Minor
    Found in tests/TestCase/ResourceTestCase.php - About 1 hr to fix

      Method testCreateCustomerPayment has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function testCreateCustomerPayment()
    {
        // Mock the payment
        $paymentMock = $this->getPayment();
      Severity: Minor
      Found in tests/Customer/Payment/CustomerPaymentCreateTest.php - About 1 hr to fix

        Method testCreatePayment has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testCreatePayment()
    {
        // Mock the payment
        $paymentMock = $this->getPayment();
        Severity: Minor
        Found in tests/Payment/PaymentCreateTest.php - About 1 hr to fix

          Method testCreateCustomerSubscription has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function testCreateCustomerSubscription()
    {
        // Mock the subscription
        $subscriptionMock = $this->getSubscription();
          Severity: Minor
          Found in tests/Customer/Subscription/CustomerSubscriptionCreateTest.php - About 1 hr to fix

            Method testCreateCustomerMandate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testCreateCustomerMandate()
    {
        // Mock the mandate
        $mandateMock = $this->getCustomerMandate();
            Severity: Minor
            Found in tests/Customer/Mandate/CustomerMandateCreateTest.php - About 1 hr to fix

              Method parseData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function parseData($name, $value)
    {
        if (!empty($value)) {
            if (preg_match('/.+(Datetime|Date)$/', $name)) {
                // ISO 8601 Date
              Severity: Minor
              Found in src/Model/Base/ModelBase.php - About 1 hr to fix

                Method update has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function update($name = null, $email = null, $metadata = null, $locale = null, $customerId = null)
    {
        // Check metadata type if given
        if (isset($metadata) && !is_object($metadata) && !is_array($metadata)) {
            throw new \InvalidArgumentException('Metadata argument must be of type array or object.');
                Severity: Minor
                Found in src/Resource/CustomerResource.php - About 1 hr to fix

                  Function create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function create($amount, $interval, $description, $times = null, array $opts = array())
    {
        // Check number of times
        if (isset($times) && ($times < 1 || !is_numeric($times))) {
            throw new \InvalidArgumentException("Invalid number of charges for this subscription. Please enter a number of 1 or more, or leave null for an ongoing subscription.");
                  Severity: Minor
                  Found in src/Resource/Customer/SubscriptionResource.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function create($amount, $description, $redirectUrl, $metadata = null, array $opts = array())
                  Severity: Minor
                  Found in src/Resource/Customer/PaymentResource.php - About 35 mins to fix

                    Method createFirstRecurring has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function createFirstRecurring($amount, $description, $redirectUrl, $metadata = nul, array $opts = array())
                    Severity: Minor
                    Found in src/Resource/Customer/PaymentResource.php - About 35 mins to fix

                      Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function create($amount, $description, $redirectUrl, $metadata = null, array $opts = array())
                      Severity: Minor
                      Found in src/Resource/PaymentResource.php - About 35 mins to fix

                        Method update has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function update($name = null, $email = null, $metadata = null, $locale = null, $customerId = null)
                        Severity: Minor
                        Found in src/Resource/CustomerResource.php - About 35 mins to fix

                          Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public function create($amount, $interval, $description, $times = null, array $opts = array())
                          Severity: Minor
                          Found in src/Resource/Customer/SubscriptionResource.php - About 35 mins to fix

                            Function getResourceID has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                protected function getResourceID($resource, $type, &$property = null)
    {
        // Get short resource type class name (payment, customer...)
        $name = strtolower(substr($type, strrpos($type, '\\') + 1));
                            Severity: Minor
                            Found in src/Resource/Base/ResourceBase.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Missing class import via use statement (line '110', column '23').
                            Open

                                        throw new \InvalidArgumentException('Request data failed to encode to JSON format.');
                            Severity: Minor
                            Found in src/Request.php by phpmd

                            MissingImport

                            Since: 2.7.0

                            Importing all external classes in a file through use statements makes them clearly visible.

                            Example

                            function make() {
    return new \stdClass();
}

                            Source http://phpmd.org/rules/cleancode.html#MissingImport

                            Severity
                            Category
                            Status
                            Source
                            Language